Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crashes in Power Spectrum Tool #132

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix crashes in Power Spectrum Tool #132

wants to merge 1 commit into from

Conversation

darktemplarbasealt
Copy link
Contributor

No description provided.

@cbrnr cbrnr mentioned this pull request Sep 15, 2021
Merged
@cbrnr
Copy link
Owner

cbrnr commented Sep 24, 2021

Can you describe how I can reproduce the crashes? I would like to verify that this fix addresses the problem appropriately.

@darktemplarbasealt
Copy link
Contributor Author

Steps to reproduce:

  1. open XDF file: File -> Open
    I'll send example file by email
  2. Change options:
    Tools -> Power Spectrum -> Event Time Channel -> Select All -> MouseButtonLeft pressed
    Set Length=20s and Start before=2s
  3. Press "OK". Application crashes.

As far as I know Start + Length is out of bounds for example file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@darktemplarbasealt @cbrnr