Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Python 3.13 #241

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Add support for Python 3.13 #241

wants to merge 9 commits into from
+36 −41

Conversation

cbrnr
Copy link
Owner

@cbrnr cbrnr commented Oct 9, 2024

In addition, bump dependencies.

cbrnr
cbrnr commented Oct 9, 2024
View reviewed changes
Copy link
Owner Author

@cbrnr cbrnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NumPy errors are all in wfdb, I'll try to fix them (will link the corresponding PR once it's up).

@cbrnr cbrnr linked an issue Oct 14, 2024 that may be closed by this pull request
Python 3.13 roadmap #235
Open
3 tasks
cbrnr
cbrnr commented Jan 17, 2025
View reviewed changes
Copy link
Owner Author

@cbrnr cbrnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to wait for MIT-LCP/wfdb-python#511 (and a new release).

@cbrnr
Copy link
Owner Author

cbrnr commented Jan 22, 2025

This seems to work nicely. However, I don't like that some dependencies are installed in cibuildwheel.yml since everything should already be defined in pyproject.toml. Specifically, we created the cibw extras group exactly for this purpose. @larsoner do you know how the "Triage dependencies" step can be modified to use this extras group instead of manually installing packages?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python 3.13 roadmap
1 participant
@cbrnr