Feature extern c #183
Merged
Feature extern c #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We declare dummy prototypes to cater to the needs of GNU indent when it encounters our SC_EXTERN_C_BEGIN macros plus a semicolon, and likewise for SC_EXTERN_C_END. To make sure the semicolon is not semantically superfluous, we add said prototypes. These are now made the same for both C and C++ compile of libsc.
We had previously only provided the prototype for the function hack to work around the needs of GNU indent. Now adding the code.
|
Pinging @dutkalex for checking this with clang-17, if you like. |
Looks good! No more warnings :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set C linkage for hack prototype
Following up on issue #179.
Proposed changes: Make the prototype of sc_extern_c_hack_2 have C linkage, which allows to use the same names of the hack functions for both C and C++. Hopefully this avoids the warning with Clang. (Wondering why Clang would complain about declaring an unused prototype in a header, which is what headers do.)
For completeness, also implement the two dummy functions even though they are never called from the code.