CMake: Fix pkgconf install path in symbolic link #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elykwilliams
changed the title
elykwilliams
changed the title
|
Thanks! So far we had not given the pkgconfig support much coverage. If we were eventually to arrive at installed .pc files that actually work the way Linux distributions need it to, and are identical between autotools and CMake, that would be another major step forward. |
|
We may augment our CI eventually to check into the generated .pc contents. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix pkgconf install path in symbolic link
Closes issue #187.
Proposed changes:
The
CMAKE_INSTALL_PATHwas being set an configure time and not using the value present at install time. This change will allow all supported cmake versions to specify the install prefix when installing viacmake --install . --prefix=/path/to/install.Note that this change will cause cmake to issue a fatal error and abort install if the symbolic link is not created, instead of failing passively as before.