Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fields types for sc3_array_t #210

Open
wants to merge 1 commit into
base: feature-sc3
Choose a base branch
from

Conversation

mkirilin
Copy link
Collaborator

@mkirilin mkirilin commented Dec 5, 2024

Fix fields types for sc3_array_t

Proposed changes:

This PR fixes the ,,sc3_array_t::ecount and ,,sc3_array_t::ealloc types from ,,int to ,,size_t as it is in sc_array_t. It will be beneficial for solving some type conflicts in shared memory partition and iteration algorithms.

@mkirilin mkirilin requested a review from cburstedde December 5, 2024 13:21
@cburstedde
Copy link
Owner

Wondering, why do we have 76 changed files? Is there no way to have the origin and new branch receive the same merges beforehand?

@mkirilin
Copy link
Collaborator Author

I tried to push my feature-sc3 with merged the latest develop branch into yours feature-sc3. It caused the significant diff. Now I undid the latest develop merge.

I suppose, it caused the CI fail with MacOS, as I think this issue was solved on the develop branch.

The one suggestion would be to update ours both feature-sc3 branches with the newest develop.

@cburstedde
Copy link
Owner

Thanks! Yes, updating both branches will make sense. I'll do this once I've released the next version of sc.

Using size_t consistently for memory sizes/locations makes sense. I would just suggest to rename a standard int variable like 'i' to 'iz' or similar to avoid any risk of confusion. ecount etc. can remain as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants