Number fixes #89
Closed
Number fixes #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank for the fix! I'm afraid I've gone for a slightly different approach in fb0f323, which should match what PUC Lua 5.2 does a little more closely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #88. I decided to keep the Lua 5.3 behavior that hexadecimal numbers without a radix point or exponent wrap-around (which was already the current Cobalt behavior) so that it wouldn't need to be changed again whenever Cobalt updates to Lua 5.3.
Also fixes another bug I found where 2^63 had its last digit incorrectly displaying as 7 instead of 8. This was happening because
Math.pow(2, 63) == (long)Math.pow(2, 63): thelongwas getting converted to adoublein the comparison here, making both equal, even though(long)Math.pow(2, 63)is 9223372036854775807 andMath.pow(2, 63)is 9223372036854775808.