Skip to content

Commit

Permalink
docs: comments on 2 vocabulary choices
Browse files Browse the repository at this point in the history
potential for our custom descriptiontypes for various note types
and also to add to the role_map for contributor roles
couple referencs to Art + Rare Materials BIBFRAME extension
  • Loading branch information
phette23 committed Nov 18, 2024
1 parent 499a396 commit 5581659
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 2 additions & 1 deletion migrate/maps.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,9 @@

# creator/contributor roles
# ! NOTE cast terms to LOWERCASE before using this map. Our metadata is inconsistent between title case and lowercase.
# MODS (uses MARC list): https://www.loc.gov/marc/relators/relaterm.html
# MODS (uses MARC list): https://www.loc.gov/marc/relators/relaterm.html | https://id.loc.gov/vocabulary/relators.html
# Invenio roles: https://github.com/inveniosoftware/invenio-rdm-records/blob/master/invenio_rdm_records/fixtures/data/vocabularies/roles.yaml
# Another option: https://art-and-rare-materials-bf-ext.github.io/arm/v1.0/vocabularies/relator.html
# Maps from our existing values of mods/name/role/roleTerm to terms either in the MARC relator list of the Invenio roles vocab.
role_map: dict[str, str] = {
# 2 FASHN items, person is creator/artist
Expand Down
2 changes: 2 additions & 0 deletions migrate/record.py
Original file line number Diff line number Diff line change
Expand Up @@ -267,6 +267,8 @@ def descriptions(self) -> list[dict[str, Any]]:
# /api/vocabularies/descriptiontypes
# types: abstract, methods, series-information, table-of-contents, technical-info, other
# https://datacite-metadata-schema.readthedocs.io/en/4.5/properties/description/#a-descriptiontype
# ? do we want to define our own description types?
# One option: https://art-and-rare-materials-bf-ext.github.io/arm/v1.0/vocabularies/note_types.html

desc = []
if len(self.abstracts) > 1:
Expand Down

0 comments on commit 5581659

Please sign in to comment.