✨ QuickTrace: An Efficient Contour Tracing Algorithm for Defect Robustness Simulation #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: GitHub Actions <actions@github.com>
# Conflicts: # bindings/pyfiction/include/pyfiction/algorithms/simulation/sidb/assess_physical_population_stability.hpp # bindings/pyfiction/include/pyfiction/pybind11_mkdoc_docstrings.hpp # docs/algorithms/sidb_simulation.rst # include/fiction/algorithms/simulation/sidb/assess_physical_population_stability.hpp # include/fiction/algorithms/simulation/sidb/operational_domain.hpp # test/utils/blueprints/layout_blueprints.hpp
Signed-off-by: GitHub Actions <actions@github.com>
Signed-off-by: GitHub Actions <actions@github.com>
Signed-off-by: GitHub Actions <actions@github.com>
Signed-off-by: GitHub Actions <actions@github.com>
# Conflicts: # test/algorithms/physical_design/design_sidb_gates.cpp # test/algorithms/simulation/sidb/assess_physical_population_stability.cpp # test/algorithms/simulation/sidb/critical_temperature.cpp # test/algorithms/simulation/sidb/maximum_defect_influence_position_and_distance.cpp
marcelwa
requested changes
Jan 8, 2025
include/fiction/algorithms/simulation/sidb/defect_clearance.hpp
Outdated
Show resolved
Hide resolved
...s/mnt/pyfiction/include/pyfiction/algorithms/simulation/sidb/physically_valid_parameters.hpp
Outdated
Show resolved
Hide resolved
.../pyfiction/include/pyfiction/algorithms/simulation/sidb/potential_to_distance_conversion.hpp
Outdated
Show resolved
Hide resolved
...gs/mnt/pyfiction/test/algorithms/simulation/sidb/test_groundstate_from_simulation_results.py
Show resolved
Hide resolved
include/fiction/algorithms/simulation/sidb/can_positive_charges_occur.hpp
Outdated
Show resolved
Hide resolved
test/algorithms/simulation/sidb/positive_charge_existence_check.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: GitHub Actions <actions@github.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
...yfiction/include/pyfiction/algorithms/simulation/sidb/groundstate_from_simulation_result.hpp
Show resolved
Hide resolved
...yfiction/include/pyfiction/algorithms/simulation/sidb/groundstate_from_simulation_result.hpp
Show resolved
Hide resolved
marcelwa
approved these changes
Jan 13, 2025
Thank you for helping to improve the code! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements three key methods---Grid Search, Random Sampling, and QuickTrace (based on Contour Tracing)---to identify and analyze the atomic defect operational domain.
Checklist: