Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Option for efficient determination of non-operational status #602

Merged
merged 124 commits into from
Jan 14, 2025

Conversation

Drewniok
Copy link
Collaborator

@Drewniok Drewniok commented Dec 3, 2024

Description

This PR adds an option to efficiently determine if a layout is non-operational. This is achieved by applying the pruning strategies from QuickCell.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have added a changelog entry.
  • I have created/adjusted the Python bindings for any new or updated functionality.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@Drewniok Drewniok added the enhancement New feature or request label Dec 3, 2024
@Drewniok Drewniok self-assigned this Dec 3, 2024
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 95.66929% with 22 lines in your changes missing coverage. Please review.

Project coverage is 98.14%. Comparing base (9ff9b53) to head (837b8ee).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...tion/algorithms/simulation/sidb/is_operational.hpp 90.55% 21 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##             main     #602    +/-   ##
========================================
  Coverage   98.14%   98.14%            
========================================
  Files         235      235            
  Lines       35810    36046   +236     
  Branches     1750     1753     +3     
========================================
+ Hits        35145    35379   +234     
- Misses        664      666     +2     
  Partials        1        1            
Files with missing lines Coverage Δ
...ude/fiction/algorithms/iter/bdl_input_iterator.hpp 99.12% <100.00%> (-0.88%) ⬇️
...n/algorithms/physical_design/design_sidb_gates.hpp 98.38% <100.00%> (+6.79%) ⬆️
...imulation/sidb/calculate_energy_and_state_type.hpp 100.00% <100.00%> (ø)
...lgorithms/simulation/sidb/critical_temperature.hpp 93.33% <100.00%> (ø)
...simulation/sidb/displacement_robustness_domain.hpp 97.67% <ø> (ø)
.../algorithms/simulation/sidb/operational_domain.hpp 94.83% <100.00%> (+0.08%) ⬆️
.../algorithms/simulation/sidb/verify_logic_match.hpp 100.00% <100.00%> (ø)
include/fiction/layouts/cell_level_layout.hpp 100.00% <100.00%> (ø)
include/fiction/utils/truth_table_utils.hpp 100.00% <100.00%> (ø)
test/algorithms/iter/bdl_input_iterator.cpp 96.87% <ø> (ø)
... and 11 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ff9b53...837b8ee. Read the comment docs.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

include/fiction/utils/truth_table_utils.hpp Outdated Show resolved Hide resolved
include/fiction/utils/truth_table_utils.hpp Outdated Show resolved Hide resolved
@Drewniok Drewniok requested a review from marcelwa December 4, 2024 15:51
@Drewniok Drewniok requested a review from marcelwa January 9, 2025 09:31
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

include/fiction/utils/truth_table_utils.hpp Show resolved Hide resolved
marcelwa
marcelwa previously approved these changes Jan 13, 2025
Copy link
Collaborator

@marcelwa marcelwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also here, many thanks for the quick fixes and adjustments. This PR is ready to merge from my end 🙂

@Drewniok
Copy link
Collaborator Author

Many thanks for your help! 🙏

actions-user and others added 2 commits January 13, 2025 21:17
Signed-off-by: GitHub Actions <actions@github.com>
@Drewniok Drewniok requested a review from marcelwa January 13, 2025 21:32
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

marcelwa
marcelwa previously approved these changes Jan 13, 2025
@Drewniok Drewniok merged commit 7ba71fb into cda-tum:main Jan 14, 2025
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants