Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve codecov results #9

Merged
merged 3 commits into from
Aug 12, 2024
Merged

Improve codecov results #9

merged 3 commits into from
Aug 12, 2024

Conversation

DRovara
Copy link
Collaborator

@DRovara DRovara commented Aug 12, 2024

Description

Some parts of the codebase were incorrectly ignored from codecov. The codecov-ignored directives are updated in this pull request.

Further, this PR adds tests for parsing assertions and for equality assertions.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.8%. Comparing base (7469237) to head (6bf82f4).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##            main      #9      +/-   ##
========================================
+ Coverage   70.4%   81.8%   +11.3%     
========================================
  Files         13      12       -1     
  Lines       1599    1449     -150     
  Branches     229     194      -35     
========================================
+ Hits        1127    1186      +59     
+ Misses       472     263     -209     
Flag Coverage Δ *Carryforward flag
cpp 92.1% <100.0%> (+14.1%) ⬆️
python 18.7% <ø> (ø) Carriedforward from 7469237

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
include/common/parsing/AssertionParsing.hpp 100.0% <ø> (ø)
src/backend/dd/DDSimDebug.cpp 89.0% <ø> (+5.9%) ⬆️
src/common/parsing/AssertionParsing.cpp 96.0% <100.0%> (+32.0%) ⬆️

... and 2 files with indirect coverage changes

@DRovara DRovara merged commit 439f7da into main Aug 12, 2024
28 checks passed
@DRovara DRovara deleted the refactor/increase-codecov branch August 12, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants