-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Framework update #26
Framework update #26
Conversation
# Conflicts: # tests/test_evaluation.py
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #26 +/- ##
=======================================
+ Coverage 53.1% 54.2% +1.0%
=======================================
Files 6 6
Lines 2815 3033 +218
=======================================
+ Hits 1496 1644 +148
- Misses 1319 1389 +70
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just did a quick round of fixes and updated some things. See the individual commits for details.
Overall, this should be good to go.
You might want to also add your new QCE publication to the docs/refs.bib
and cite it in the documentation.
One thing i noticed is that the solvers.py
file contains huge amounts of code duplication and is probably 5x longer than it needs to be. However, this is nothing to be changed in this PR, but maybe something to keep in mind for a potential future refactor.
Yes, thank you. |
Framework update for the quantum week presentation