Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework update #26

Merged
merged 63 commits into from
Aug 13, 2024
Merged

Framework update #26

merged 63 commits into from
Aug 13, 2024

Conversation

DeborahVolpe
Copy link
Collaborator

Framework update for the quantum week presentation

src/mqt/qao/solvers.py Fixed Show fixed Hide fixed
src/mqt/qao/solvers.py Fixed Show fixed Hide fixed
src/mqt/qao/solvers.py Fixed Show fixed Hide fixed
@burgholzer burgholzer removed their assignment Aug 7, 2024
@nquetschlich nquetschlich self-requested a review August 7, 2024 14:49
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 57.66423% with 116 lines in your changes missing coverage. Please review.

Project coverage is 54.2%. Comparing base (9b45b8d) to head (4803988).
Report is 26 commits behind head on main.

Files with missing lines Patch % Lines
src/mqt/qao/solvers.py 57.6% 116 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main     #26     +/-   ##
=======================================
+ Coverage   53.1%   54.2%   +1.0%     
=======================================
  Files          6       6             
  Lines       2815    3033    +218     
=======================================
+ Hits        1496    1644    +148     
- Misses      1319    1389     +70     
Flag Coverage Δ
python 54.2% <57.6%> (+1.0%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@burgholzer burgholzer added dependencies Pull requests that update a dependency file enhancement Improvement of an existing feature or request minor Part of a minor release python Anything related to Python code labels Aug 12, 2024
Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just did a quick round of fixes and updated some things. See the individual commits for details.
Overall, this should be good to go.
You might want to also add your new QCE publication to the docs/refs.bib and cite it in the documentation.

One thing i noticed is that the solvers.py file contains huge amounts of code duplication and is probably 5x longer than it needs to be. However, this is nothing to be changed in this PR, but maybe something to keep in mind for a potential future refactor.

@DeborahVolpe
Copy link
Collaborator Author

Just did a quick round of fixes and updated some things. See the individual commits for details. Overall, this should be good to go. You might want to also add your new QCE publication to the docs/refs.bib and cite it in the documentation.
Thank you so much. I have also added the reference here. I have forgotten this point

One thing i noticed is that the solvers.py file contains huge amounts of code duplication and is probably 5x longer than it needs to be. However, this is nothing to be changed in this PR, but maybe something to keep in mind for a potential future refactor.

Yes, thank you.

@burgholzer burgholzer enabled auto-merge (squash) August 13, 2024 05:40
@burgholzer burgholzer merged commit 61c7860 into main Aug 13, 2024
25 checks passed
@burgholzer burgholzer deleted the update_work branch August 13, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement Improvement of an existing feature or request minor Part of a minor release python Anything related to Python code
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants