-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fidelity-aware heuristic and search graph visualization #384
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #384 +/- ##
=======================================
+ Coverage 92.3% 93.0% +0.7%
=======================================
Files 44 46 +2
Lines 4158 4875 +717
Branches 701 843 +142
=======================================
+ Hits 3838 4534 +696
- Misses 320 341 +21
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
…into fidelityHeuristic3
…into fidelityHeuristic3
…into fidelityHeuristic3
…into fidelityHeuristic3
…into fidelityHeuristic3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many many thanks again for this nice contribution.
As discussed, I quickly skimmed over everything again and checked the most important parts. You can find a couple of extremely small comments inline as part of this review. Most of them, you should just be able to collect in a batch and commit in bulk (if you agree with the suggestions of course).
After that, I'd be happy to merge this 🎉
Co-authored-by: Lukas Burgholzer <burgholzer@me.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is good to go, so let's get it in 🎉
Many thanks for all the work here. Looking forward to what's next!
I agree, let's merge👍 |
Description
Includes:
Currently, the fidelity-aware heuristic mapping is not yet compatible with dynamic initial layouting, lookahead or qubit teleportation. Therefore, I did not yet add an example for fidelity-aware mapping in Mapping.ipynb in the documentation. (I think advertising this feature outside the API reference only makes sense once it is more fleshed out)
Checklist: