Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hybrid Neutral Atom Mapper #458

Merged
merged 116 commits into from
Jun 3, 2024
Merged

Hybrid Neutral Atom Mapper #458

merged 116 commits into from
Jun 3, 2024

Conversation

lsschmid
Copy link
Collaborator

@lsschmid lsschmid commented May 24, 2024

Description

Adds the hybrid mapping functionality for Neutral Atom Hardware.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 90.39281% with 203 lines in your changes missing coverage. Please review.

Project coverage is 90.4%. Comparing base (7793ecc) to head (289cb03).
Report is 83 commits behind head on main.

Files with missing lines Patch % Lines
src/hybridmap/MoveToAodConverter.cpp 76.6% 83 Missing ⚠️
src/hybridmap/HybridNeutralAtomMapper.cpp 92.4% 59 Missing ⚠️
src/hybridmap/HybridAnimation.cpp 86.0% 18 Missing ⚠️
include/hybridmap/NeutralAtomUtils.hpp 74.5% 13 Missing ⚠️
src/hybridmap/NeutralAtomArchitecture.cpp 96.7% 5 Missing ⚠️
src/hybridmap/NeutralAtomLayer.cpp 95.3% 5 Missing ⚠️
include/hybridmap/HybridNeutralAtomMapper.hpp 80.0% 4 Missing ⚠️
include/hybridmap/Mapping.hpp 87.0% 4 Missing ⚠️
src/hybridmap/HardwareQubits.cpp 96.9% 4 Missing ⚠️
include/hybridmap/HardwareQubits.hpp 94.5% 3 Missing ⚠️
... and 2 more
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #458     +/-   ##
=======================================
  Coverage   90.4%   90.4%             
=======================================
  Files         68      86     +18     
  Lines       7852    9965   +2113     
  Branches    1277    1696    +419     
=======================================
+ Hits        7101    9012   +1911     
- Misses       751     953    +202     
Flag Coverage Δ
cpp 90.1% <90.3%> (+<0.1%) ⬆️
python 95.9% <ø> (ø)
Files with missing lines Coverage Δ
include/hybridmap/HybridAnimation.hpp 100.0% <100.0%> (ø)
include/hybridmap/MoveToAodConverter.hpp 100.0% <100.0%> (ø)
include/hybridmap/NeutralAtomLayer.hpp 100.0% <100.0%> (ø)
include/hybridmap/NeutralAtomScheduler.hpp 100.0% <100.0%> (ø)
src/hybridmap/NeutralAtomScheduler.cpp 100.0% <100.0%> (ø)
src/hybridmap/NeutralAtomUtils.cpp 100.0% <100.0%> (ø)
src/mqt/qmap/__init__.py 94.1% <ø> (ø)
include/hybridmap/NeutralAtomArchitecture.hpp 97.6% <97.6%> (ø)
include/hybridmap/HardwareQubits.hpp 94.5% <94.5%> (ø)
src/hybridmap/Mapping.cpp 75.0% <75.0%> (ø)
... and 9 more

... and 1 file with indirect coverage changes

include/hybridmap/Mapping.hpp Fixed Show fixed Hide fixed
src/hybridmap/HardwareQubits.cpp Fixed Show fixed Hide fixed
src/hybridmap/AodScheduler.cpp Fixed Show fixed Hide fixed
src/hybridmap/AodScheduler.cpp Fixed Show fixed Hide fixed
src/hybridmap/AodScheduler.cpp Fixed Show fixed Hide fixed
src/hybridmap/HybridNeutralAtomMapper.cpp Fixed Show fixed Hide fixed
@lsschmid lsschmid requested a review from burgholzer June 2, 2024 07:48
@lsschmid lsschmid force-pushed the hybrid-na-mapper branch from b17af70 to a662ae4 Compare June 3, 2024 08:53
@lsschmid lsschmid added this to the Neutral Atom Compilation milestone Jun 3, 2024
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, all conversations have been resolved, the CI is green, and follow-up issues have been created. ✅
So I think we are good to go here for now! 🎉

Thanks for all your work on the PR! 🙏🏼
I'll merge once CI passes.

@burgholzer burgholzer enabled auto-merge (squash) June 3, 2024 15:58
@burgholzer burgholzer merged commit aceab85 into main Jun 3, 2024
34 checks passed
@burgholzer burgholzer deleted the hybrid-na-mapper branch June 3, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Anything related to C++ code feature New feature or request minor Changes leading to a minor version increase python Anything related to Python code
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants