Ability to export rules as YAML #214
Conversation
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://icy-flower-095494b10-214.centralus.azurestaticapps.net |
drewcdisc
changed the title
There was a problem hiding this comment.
I've completed my review and I'm happy to approve. I checked the following:
- Spot checked downloaded YAML vs manually copied YAML for some rules, with no discrepancies found.
- Confirmed that export as YAML works as expected for different types of filtering (column header, search bar)
- Confirmed that export of debugging artifacts and rules as CSV still work as expected.
- Performed high-level code review, with nothing unexpected seen.
The only thing that caught my eye is that the progress icon flashes to red periodically when downloading a large number of rules. I assume this may have something to do with pagination. It also happens if you close the progress indicator by click on the X. However, it doesn't seem to affect the export functionality, so I am still happy to approve and am not requesting a change.
There was a problem hiding this comment.
I am also happy to approve.
- YAML and CSV exports working as intended with no discrepancies with new export functionality vs. rules library yaml.
- Debugging artifacts also works as intended without error.
- passes high level code review
I too got the status bar flashing red issue that Richard observed when using chrome and downloading a large amount of rules. Firefox freezes briefly upon making the request for an unfiltered download of a large amount of rules until the request is completed. Both do process the request so I agree with Richard that shouldn't be an issue.
|
@ASL-rmarshall @SFJohnson24 |
gerrycampion
deleted the
83-there-needs-to-be-a-way-to-run-unpublished-rules
branch
Code is live here: https://icy-flower-095494b10-dev.centralus.azurestaticapps.net/
(Or run locally)
To test,
Export Rules as YAMLYou can view the yaml files that are downloaded. They should match the yaml of the currently filtered rules