Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SUPP-- Interim Fix #232

Merged
merged 1 commit into from
Jul 22, 2024
Merged

SUPP-- Interim Fix #232

merged 1 commit into from
Jul 22, 2024

Conversation

SFJohnson24
Copy link
Collaborator

No description provided.

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://icy-flower-095494b10-232.centralus.azurestaticapps.net

@SFJohnson24 SFJohnson24 mentioned this pull request Jul 18, 2024
Open
@SFJohnson24 SFJohnson24 requested a review from RamilCDISC July 18, 2024 17:39
@RamilCDISC
Copy link
Collaborator

Whie Testing for CG0017, I entered 3 different dataset files to the rule editor. For each it gave same error. Unexpected token '<', "<!doctype "... is not valid JSON Attached is the screenshot of the error. I used dataset from positive folder of CG0017 on the sharepoint. I think the previous PR has added this bug

232

RamilCDISC
RamilCDISC approved these changes Jul 22, 2024
View reviewed changes
Copy link
Collaborator

@RamilCDISC RamilCDISC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR successfully implements the older way of reading the name of supp dataset names. The supp datasets are read as SUPP-- similar to how previously engine used to read. The bug mentioned before will be resoved by another PR. This PR can be valdiated by checking the name of dataset in the request body on the rule editor. Following screenshot shows correct reading of the dataset name.

744-2

@RamilCDISC RamilCDISC merged commit 419703c into main Jul 22, 2024
4 checks passed
@RamilCDISC RamilCDISC deleted the Supp_Domain branch July 22, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RamilCDISC RamilCDISC RamilCDISC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SFJohnson24 @RamilCDISC