-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Include
not working with deno runtime
#2704
base: 2.x
Are you sure you want to change the base?
Conversation
5c25dad
to
ffa319d
Compare
@iliapolo cc |
@stevefan1999-personal can you please elaborate on how this is related to Deno support? Also, you mentioned:
Which one? |
Because Deno does not have a I don't remember starting from which Node you can use mjs as file extension running as ESM module exactly though. |
Include
not working with deno runtime
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ESM has been available as a stable feature since Node12 so we are good here.
Thanks!
@stevefan1999-personal there's a self-mutation failure: diff --git a/.projen/tasks.json b/.projen/tasks.json
index 665e4a0..8fb9228 [10](https://github.com/cdk8s-team/cdk8s-core/actions/runs/10772681725/job/29870857444?pr=2704#step:8:11)0644
--- a/.projen/tasks.json
+++ b/.projen/tasks.json
@@ -494,4 +494,4 @@
"PATH": "$(npx -c \"node --print process.env.PATH\")"
},
"//": "~~ Generated by projen. To modify, edit .projenrc.js and run \"npx projen\"."
-}
\ No newline at end of file
+} It means some auto-generated files have not been fully committed. You need to run |
What other roadblocks are you aware of? |
There is a problem with the type checker. While it is not fatal it is annoying and hard for debugging |
Can you elaborate? |
Reminder ^ |
This PR has not received a response in a while and will be closed soon. If you want to keep it open, please leave a comment below @mentioning a maintainer. |
Any chance of revisiting this? I've also just run into this using Deno. @iliapolo |
Im happy to merge this. Just needs a fix to the build from @stevefan1999-personal . |
@iliapolo sure let me take a look this night and see |
82d12ff
to
0d8d382
Compare
Signed-off-by: Steve Fan <29133953+stevefan1999-personal@users.noreply.github.com>
Signed-off-by: Steve Fan <29133953+stevefan1999-personal@users.noreply.github.com>
Signed-off-by: Steve Fan <29133953+stevefan1999-personal@users.noreply.github.com>
Signed-off-by: Steve Fan <29133953+stevefan1999-personal@users.noreply.github.com>
Signed-off-by: Steve Fan <29133953+stevefan1999-personal@users.noreply.github.com>
30c6b38
to
1034dcf
Compare
Related to cdk8s-team/cdk8s#2171 but with a consequence of a modern version of Node must be required. This is one of the few roadblocks left.