feat(pv): iSCSI Persistent Volume and possibility to bind PVs to PVCs in any namespace
#3285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julien DOCHE <julien.doche@datadoghq.com>
Signed-off-by: Julien DOCHE <julien.doche@datadoghq.com>
Signed-off-by: Julien DOCHE <julien.doche@datadoghq.com>
Signed-off-by: Julien DOCHE <julien.doche@datadoghq.com>
Signed-off-by: Julien DOCHE <julien.doche@datadoghq.com>
St0rmingBr4in
changed the title
|
@iliapolo Could you take a look please ? |
iliapolo
changed the title
iSCSI Persistent Volume and possibility to bind PVs to PVCs in any namespace
iliapolo
requested changes
Apr 7, 2024
| @@ -208,10 +209,10 @@ export class PersistentVolume extends base.Resource implements IPersistentVolume | |||
| * | |||
| * @see https://kubernetes.io/docs/concepts/storage/persistent-volumes/#reserving-a-persistentvolume | |||
| */ | |||
| public reserve(): pvc.PersistentVolumeClaim { | |||
| public reserve(namespace?: string): pvc.PersistentVolumeClaim { | |||
There was a problem hiding this comment.
We don't normally use optional positional arguments. Instead, create a PersistentVolumeReserveOptions interface.
Also this requires a test.
| metadata: { name: `pvc-${this.name}`, namespace: this.metadata.namespace }, | ||
|
|
||
| metadata: { name: `pvc-${this.name}` }, | ||
| namespace: namespace ? namespace : this.metadata.namespace, |
There was a problem hiding this comment.
Suggested change
| namespace: namespace ? namespace : this.metadata.namespace, | |
| namespace: namespace ?? this.metadata.namespace, |
|
Awesome, thanks for this! |
iliapolo
added
backport-to-k8s-29/main
|
This PR has not received a response in a while and will be closed soon. If you want to keep it open, please leave a comment below @mentioning a maintainer. |
github-actions
bot
added
the
closing-soon
iliapolo
added
backport-to-k8s-30/main
github-actions
bot
added
closed-for-staleness
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the IscsiPersistentVolume class to be able to generate iSCSI backed persistent volumes.
This also adds the ability to bind a PV to a PVC in another namespace than the default one.