Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pod): shareProcessNamespace #3674

Closed
wants to merge 2 commits into from

Conversation

chensjlv
Copy link

@chensjlv chensjlv commented Feb 8, 2024

add shareProcessNamespace to pod spec. Cannot find it anywhere.

https://kubernetes.io/docs/tasks/configure-pod-container/share-process-namespace/

Signed-off-by: Mike Chen <yi.chen.it@gmail.com>
@iliapolo iliapolo changed the base branch from k8s-27/main to k8s-28/main February 28, 2024 17:46
@iliapolo iliapolo changed the title feat(pod-spec): add shareProcessNamespace to k8s-27 feat(pod): shareProcessNamespace Apr 7, 2024
Copy link
Member

@iliapolo iliapolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@iliapolo
Copy link
Member

iliapolo commented Apr 7, 2024

Please allow updates from maintainers or update the PR manually

@iliapolo iliapolo changed the base branch from k8s-28/main to k8s-29/main April 15, 2024 06:11
@iliapolo iliapolo changed the base branch from k8s-29/main to k8s-30/main June 4, 2024 15:26
@iliapolo iliapolo added backport-to-k8s-29/main Backport a PR to the k8s-30 branch and removed backport-to-k8s-27/main labels Jun 4, 2024
@chensjlv
Copy link
Author

Please allow updates from maintainers or update the PR manually

weird, I don't see the option

@chensjlv
Copy link
Author

chensjlv commented Jul 26, 2024

Please allow updates from maintainers or update the PR manually

Seems like it is not an available option for an arg account. Do you want me to create a new PR? Or what do you want me to change?

https://github.com/orgs/community/discussions/5634 😮‍💨

@iliapolo
Copy link
Member

@chensjlv The "allow update from maintainers" option allows us to do automatic updates from main as well as automatic snapshot updates. In case this isn't allowed, you need to rebase/merge from main manually, and run yarn build to regenerate the snapshots. Once the build passes and the code is up to date with main, the PR will merge.

Currently, the build is failing on a snapshot diff:

diff --git a/test/__snapshots__/container.test.ts.snap b/test/__snapshots__/container.test.ts.snap
index cc078f2..ee03dfa [10](https://github.com/cdk8s-team/cdk8s-plus/actions/runs/10117438309/job/28010509059?pr=3674#step:8:11)0644
--- a/test/__snapshots__/container.test.ts.snap
+++ b/test/__snapshots__/container.test.ts.snap
@@ -68,6 +68,7 @@ Array [
         "runAsNonRoot": true,
       },
       "setHostnameAsFQDN": false,
+      "shareProcessNamespace": false,
       "terminationGracePeriodSeconds": 30,
     },
   }

@iliapolo iliapolo added the response-requested Awaiting response from author label Sep 10, 2024
Copy link

This PR has not received a response in a while and will be closed soon. If you want to keep it open, please leave a comment below @mentioning a maintainer.

@github-actions github-actions bot added the closing-soon Issue/PR will be closing soon if no response is provided label Sep 10, 2024
@iliapolo iliapolo changed the base branch from k8s-30/main to k8s-31/main September 11, 2024 11:54
@iliapolo iliapolo added backport-to-k8s-30/main Backport a PR to the k8s-30 branch and removed backport-to-k8s-28/main labels Sep 11, 2024
@github-actions github-actions bot added closed-for-staleness Issue/PR was closed due to staleness and removed closing-soon Issue/PR will be closing soon if no response is provided labels Sep 17, 2024
@github-actions github-actions bot closed this Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-k8s-29/main Backport a PR to the k8s-30 branch backport-to-k8s-30/main Backport a PR to the k8s-30 branch closed-for-staleness Issue/PR was closed due to staleness response-requested Awaiting response from author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants