-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pod): shareProcessNamespace
#3674
Conversation
Signed-off-by: Mike Chen <yi.chen.it@gmail.com>
shareProcessNamespace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Please allow updates from maintainers or update the PR manually |
weird, I don't see the option |
Seems like it is not an available option for an arg account. Do you want me to create a new PR? Or what do you want me to change? |
@chensjlv The "allow update from maintainers" option allows us to do automatic updates from main as well as automatic snapshot updates. In case this isn't allowed, you need to rebase/merge from main manually, and run Currently, the build is failing on a snapshot diff: diff --git a/test/__snapshots__/container.test.ts.snap b/test/__snapshots__/container.test.ts.snap
index cc078f2..ee03dfa [10](https://github.com/cdk8s-team/cdk8s-plus/actions/runs/10117438309/job/28010509059?pr=3674#step:8:11)0644
--- a/test/__snapshots__/container.test.ts.snap
+++ b/test/__snapshots__/container.test.ts.snap
@@ -68,6 +68,7 @@ Array [
"runAsNonRoot": true,
},
"setHostnameAsFQDN": false,
+ "shareProcessNamespace": false,
"terminationGracePeriodSeconds": 30,
},
} |
This PR has not received a response in a while and will be closed soon. If you want to keep it open, please leave a comment below @mentioning a maintainer. |
add shareProcessNamespace to pod spec. Cannot find it anywhere.
https://kubernetes.io/docs/tasks/configure-pod-container/share-process-namespace/