Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(batch): add patch to delete the properties EksProperties and NodeProperties from JobDefinition resource #1546

Merged
merged 4 commits into from
Jan 7, 2025

Conversation

moelasmar
Copy link
Contributor

@moelasmar moelasmar commented Jan 6, 2025

add patch to delete the properties EksProperties and NodeProperties from JobDefinition resource . These properties where the Types Volumes, and EfsVolumeConfiguration are used.

This change will force to use the new Types, and not the old ones defined in the deprecated AWS Specs file.

@moelasmar moelasmar changed the title fix(batch): add patch to keep the old name of the Volumes, and EfsVolumeConfiguration types fix(batch): add patch to delete the properties EksProperties and NodeProperties from JobDefinition resource Jan 7, 2025
Copy link

github-actions bot commented Jan 7, 2025

@aws-cdk/aws-service-spec: Model database diff detected

└[~] service aws-batch
  └ resources
     └[~]  resource AWS::Batch::JobDefinition
        └ types
           ├[~] type EksContainer
           │ └      - mustRenderForBwCompat: undefined
           │        + mustRenderForBwCompat: true
           ├[~] type EksContainerEnvironmentVariable
           │ └      - mustRenderForBwCompat: undefined
           │        + mustRenderForBwCompat: true
           ├[~] type EksContainerVolumeMount
           │ └      - mustRenderForBwCompat: undefined
           │        + mustRenderForBwCompat: true
           ├[~] type EksProperties
           │ └      - mustRenderForBwCompat: undefined
           │        + mustRenderForBwCompat: true
           ├[~] type EksSecret
           │ └      - mustRenderForBwCompat: undefined
           │        + mustRenderForBwCompat: true
           ├[~] type EksVolume
           │ └      - mustRenderForBwCompat: undefined
           │        + mustRenderForBwCompat: true
           ├[~] type EmptyDir
           │ └      - mustRenderForBwCompat: undefined
           │        + mustRenderForBwCompat: true
           ├[~] type HostPath
           │ └      - mustRenderForBwCompat: undefined
           │        + mustRenderForBwCompat: true
           ├[~] type Metadata
           │ └      - mustRenderForBwCompat: undefined
           │        + mustRenderForBwCompat: true
           ├[~] type NodeProperties
           │ └      - mustRenderForBwCompat: undefined
           │        + mustRenderForBwCompat: true
           ├[~] type NodeRangeProperty
           │ └      - mustRenderForBwCompat: undefined
           │        + mustRenderForBwCompat: true
           ├[~] type PodProperties
           │ └      - mustRenderForBwCompat: undefined
           │        + mustRenderForBwCompat: true
           ├[~] type Resources
           │ └      - mustRenderForBwCompat: undefined
           │        + mustRenderForBwCompat: true
           └[~] type SecurityContext
             └      - mustRenderForBwCompat: undefined
                    + mustRenderForBwCompat: true

@aws-cdk-automation aws-cdk-automation added this pull request to the merge queue Jan 7, 2025
Merged via the queue into main with commit 0e80122 Jan 7, 2025
8 checks passed
@aws-cdk-automation aws-cdk-automation deleted the melasmar/aws_batch_newpatch_3 branch January 7, 2025 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants