-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(service-spec-importers): registry schema importers accept patches #640
feat(service-spec-importers): registry schema importers accept patches #640
Conversation
Signed-off-by: github-actions <github-actions@github.com>
@aws-cdk/aws-service-spec: No model change detected |
That's what I like to see! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks like a true refactor. if there's any real changes (beyond adding an option here and there) let me know because i missed it
packages/@aws-cdk/aws-service-spec/build/patches/service-patches/core.ts
Outdated
Show resolved
Hide resolved
I relabeled this as a feat since it's changing the interface for some |
We want to move the service patches from the generic importers package to the specific model package. Generic patches stay with the importers.
To support this, the two registry schema importers now accept an optional patcher.
With that done, we can move the (now unused) service patches to aws-service-spec and use them in the implementation over there.