Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(service-spec-importers): registry schema importers accept patches #640

Merged
merged 5 commits into from
Oct 25, 2023

Conversation

mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Oct 25, 2023

We want to move the service patches from the generic importers package to the specific model package. Generic patches stay with the importers.
To support this, the two registry schema importers now accept an optional patcher.

With that done, we can move the (now unused) service patches to aws-service-spec and use them in the implementation over there.

Signed-off-by: github-actions <github-actions@github.com>
@github-actions
Copy link

@aws-cdk/aws-service-spec: No model change detected

@mrgrain
Copy link
Contributor Author

mrgrain commented Oct 25, 2023

@aws-cdk/aws-service-spec: No model change detected

That's what I like to see!

Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks like a true refactor. if there's any real changes (beyond adding an option here and there) let me know because i missed it

@mrgrain mrgrain changed the title refactor(aws-service-spec): service patches are only relevant to aws-service-spec feat(service-spec-importers): registry schema importers accept patches Oct 25, 2023
@mrgrain
Copy link
Contributor Author

mrgrain commented Oct 25, 2023

this looks like a true refactor. if there's any real changes (beyond adding an option here and there) let me know because i missed it

I relabeled this as a feat since it's changing the interface for some service-spec-importers. But aside from the additional option, no changes and mostly copying files around.

@aws-cdk-automation aws-cdk-automation added this pull request to the merge queue Oct 25, 2023
Merged via the queue into main with commit 05f4047 Oct 25, 2023
8 checks passed
@aws-cdk-automation aws-cdk-automation deleted the mrgrain/refactor/patches-are-not-universal branch October 25, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants