Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

96 post upgrade snapshot and report generation skipped for firewalls #98

Conversation

cdot65
Copy link
Owner

@cdot65 cdot65 commented Feb 25, 2024

Checklist for This Pull Request

🚨Please adhere to the guidelines for contributing to this repository.

  • Ensure you are submitting your pull request to a branch dedicated to a specific topic/feature/bugfix. Avoid using the master branch for pull requests.
  • Target your pull request to the main development branch in this repository.
  • Ensure your commit messages follow the project's preferred format.
  • Check that your code additions do not fail any linting checks or unit tests.

Pull Request Description

This pull request addresses a critical bug identified in the post-upgrade process of the firewall upgrade script. Previously, the generation of post-upgrade snapshots and diff reports was skipped if a settings.yaml file was not present in the working directory. This pull request ensures that these crucial steps are executed regardless of the settings.yaml presence, thus guaranteeing the availability of post-upgrade snapshots and reports for every upgrade.

What does this pull request accomplish?

  • Feature addition
  • Bug fix
  • Performance improvement
  • Refactoring
  • Documentation update
  • Other

Are there any breaking changes included?

  • Yes
  • No

Is there anything the reviewers should know?

This pull request introduces updates various portions of the documentation.

@cdot65 cdot65 added the documentation Improvements or additions to documentation label Feb 25, 2024
@cdot65 cdot65 self-assigned this Feb 25, 2024
@cdot65 cdot65 merged commit 58a42f1 into main Feb 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant