remove the resize event listener when the component unmounts, may cau…

…se a memory leak
cellosignal · Jul 19, 2018 · c87b8f9 · c87b8f9
1 parent ac7bbf7
commit c87b8f9
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/package.json b/package.json
@@ -49,4 +49,4 @@
     "webpack-cli": "^2.0.10",
     "webpack-merge": "^4.1.2"
   }
-}
+}
diff --git a/src/provider.js b/src/provider.js
@@ -18,7 +18,14 @@ export default class Provider extends Component {
     this.tabs = document.querySelectorAll('a');
 
     this.checkMobile();
+    this.handleDebouncedCheck();
+  }
+
+  componentWillUnmount() {
+    window.removeEventListener('resize', this.handleDebouncedCheck, true);
+  }
 
+  handleDebouncedCheck = () => {
     window.addEventListener(
       'resize',
       debounce(() => this.checkMobile(this.props), 66)
-Original file line number
+Diff line change
@@ Expand Up / @@ -49,4 +49,4 @@ @@
         "webpack-cli": "^2.0.10",
         "webpack-merge": "^4.1.2"
       }
-    }
+    }