Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

draft: add offset when in south hemisphere if aligning on grid #36

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

draft: add offset when in south hemisphere if aligning on grid #36

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions tsd/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,7 +385,7 @@ def pyproj_transform(x, y, in_crs, out_crs, z=None):
return transformer.transform(x, y, z)


def utm_bbx(aoi, epsg=None, r=None, offset=(0, 0)):
def utm_bbx(aoi, epsg=None, r=None, offset=None):
"""
Compute UTM bounding box of a longitude, latitude AOI.

Expand All @@ -394,7 +394,7 @@ def utm_bbx(aoi, epsg=None, r=None, offset=(0, 0)):
epsg (int): EPSG code of the desired UTM zone
r (int): if not None, round bounding box vertices to vertices of an
r-periodic grid
offset (tuple): origin of the r-periodic grid
offset (tuple or None): origin of the r-periodic grid

Returns:
ulx, uly, lrx, lry (floats): bounding box upper left (ul) and lower
Expand All @@ -405,6 +405,13 @@ def utm_bbx(aoi, epsg=None, r=None, offset=(0, 0)):
lon, lat = np.mean(aoi['coordinates'][0][:-1], axis=0)
epsg = compute_epsg(lon, lat)

if epsg < 32601 or (epsg > 32660 and epsg < 32701) or epsg > 32760:
raise ValueError(
f'Provided EPSG code "{epsg}" do not correspond to an UTM zone')

if offset is None: # offset of 40 meters for south hemisphere
offset = (0, -40) if epsg > 32700 else (0, 0)

# convert all polygon vertices coordinates from (lon, lat) to utm
lons, lats = np.asarray(aoi['coordinates'][0]).T
xs, ys = pyproj_transform(lons, lats, 4326, epsg)
Expand Down