fix(common/engine_conf): multiple inheritence broken because of a mis… #1680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sing flag enabled
|
Important Review skippedAuto reviews are limited to specific labels. Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
jean-christophe81
approved these changes
Sep 9, 2024
sechkem
approved these changes
Sep 9, 2024
…tead of the new one
bouda1
added a commit
that referenced
this pull request
Sep 25, 2024
#1680) * fix(common/engine_conf): multiple inheritence broken because of a missing flag enabled * fix(common/log_v2): segfault in centengine fixed * fix(engine/config/applier): bad use of std::equal * fix(tests/engine): new test * fix(broker/neb): cbmod was linked with not needed libraries * fix(broker/lua): a memory leak introduced with the new openssl md5 fixed * fix(tests/engine): a new test to validate the good behavior of inheritance * enh(cmake): new option LEGACY_ENGINE to compile the legacy engine instead of the new one * fix(gh/alma8): maxscale repo is disabled on alma8 * fix(cmake): issues with dependencies * enh(gha): new possibility to save packages as artifacts REFS: MON-147499
sechkem
pushed a commit
that referenced
this pull request
Sep 25, 2024
#1680) * fix(common/engine_conf): multiple inheritence broken because of a missing flag enabled * fix(common/log_v2): segfault in centengine fixed * fix(engine/config/applier): bad use of std::equal * fix(tests/engine): new test * fix(broker/neb): cbmod was linked with not needed libraries * fix(broker/lua): a memory leak introduced with the new openssl md5 fixed * fix(tests/engine): a new test to validate the good behavior of inheritance * enh(cmake): new option LEGACY_ENGINE to compile the legacy engine instead of the new one * fix(gh/alma8): maxscale repo is disabled on alma8 * fix(cmake): issues with dependencies * enh(gha): new possibility to save packages as artifacts REFS: MON-147499
bouda1
added a commit
that referenced
this pull request
Oct 3, 2024
#1680) * fix(common/engine_conf): multiple inheritence broken because of a missing flag enabled * fix(common/log_v2): segfault in centengine fixed * fix(engine/config/applier): bad use of std::equal * fix(tests/engine): new test * fix(broker/neb): cbmod was linked with not needed libraries * fix(broker/lua): a memory leak introduced with the new openssl md5 fixed * fix(tests/engine): a new test to validate the good behavior of inheritance * enh(cmake): new option LEGACY_ENGINE to compile the legacy engine instead of the new one * fix(gh/alma8): maxscale repo is disabled on alma8 * fix(cmake): issues with dependencies * enh(gha): new possibility to save packages as artifacts REFS: MON-147499
mushroomempires
added a commit
that referenced
this pull request
Oct 4, 2024
* chore(deps): bump actions/upload-artifact from 4.3.4 to 4.4.0 Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.3.4 to 4.4.0. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@0b2256b...5076954) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * enh(clib):Remove basic/interruption_error (#1650) * Add pb_neb_lib dependencies to centenginestats * Add pb_bam_lib dependencies to engine_legacy_conf REFS: MON-147186 * no engine_otl_endpoint parameter in telegraf config (#1676) * fix(common/engine_conf): multiple inheritence broken because of a mis… (#1680) * fix(common/engine_conf): multiple inheritence broken because of a missing flag enabled * fix(common/log_v2): segfault in centengine fixed * fix(engine/config/applier): bad use of std::equal * fix(tests/engine): new test * fix(broker/neb): cbmod was linked with not needed libraries * fix(broker/lua): a memory leak introduced with the new openssl md5 fixed * fix(tests/engine): a new test to validate the good behavior of inheritance * enh(cmake): new option LEGACY_ENGINE to compile the legacy engine instead of the new one * fix(gh/alma8): maxscale repo is disabled on alma8 * fix(cmake): issues with dependencies * enh(gha): new possibility to save packages as artifacts REFS: MON-147499 * enh(ci): run promote job in dry-run mode on testing branches (#1691) * MON 137835 cma windows robot tests (#1555) * add wsl robot test * fix(engine): host's name instead of template name as alias (#1690) * (fix(engine): host's name instead of template name as alias * fix(Engine): review code REFS: MON-16261 * fix(ci): check PR status from head branch name (#1707) * fix(broker/bbdo):grpc_stream.proto is bad generated (#1713) * fix(broker/bbdo):grpc_stream.proto is bad generated * fix(broker/bbdo): review code REFS: MON- 147911 * fix(ci): legacy conf engine enabled * enh(ci): detect automatically cloud versions (#1712) * fix(broker/neb): fix bbdov2 hostgroup to correctly set enabled flag (#1720) We were not looking for the correct nebtype for updates. * MON-148688-telegraf-certificate-parameters-harmonization (#1716) REFS:MON-148688 * Mon 131997 cma telegraf whitelist (#1723) * telegraf conf_server sues conf_helper * whitelist implementation * add whitelist test * add whitelist test * installer (#1715) dlg and files installer agent is a windows service add agent version resources first version of installer writer review add installer to CMakeLists.txt add comments Apply suggestions from code review Co-authored-by: sechkem <sechkem@ext.centreon.com> Co-authored-by: cg-tw <83637804+cg-tw@users.noreply.github.com> * chore(deps): bump actions/upload-artifact from 4.3.4 to 4.4.0 Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.3.4 to 4.4.0. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@0b2256b...5076954) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: sechkem <sechkem@ext.centreon.com> Co-authored-by: jean-christophe81 <98889244+jean-christophe81@users.noreply.github.com> Co-authored-by: David Boucher <dboucher@centreon.com> Co-authored-by: Kevin Duret <kduret@centreon.com> Co-authored-by: Vincent Untz <vuntz@centreon.com> Co-authored-by: cg-tw <83637804+cg-tw@users.noreply.github.com> Co-authored-by: Paul Oureib <poureib@centreon.com>
mushroomempires
added a commit
that referenced
this pull request
Oct 10, 2024
* chore(deps): bump docker/build-push-action from 6.5.0 to 6.9.0 (#1734) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 6.5.0 to 6.9.0. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@5176d81...4f58ea7) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump actions/checkout from 4.1.1 to 4.2.0 (#1724) Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.1 to 4.2.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4.1.1...d632683) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump actions/setup-python from 5.1.1 to 5.2.0 (#1659) Bumps [actions/setup-python](https://github.com/actions/setup-python) from 5.1.1 to 5.2.0. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@39cd149...f677139) --- updated-dependencies: - dependency-name: actions/setup-python dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump actions/upload-artifact from 4.3.4 to 4.4.0 (#1658) * chore(deps): bump actions/upload-artifact from 4.3.4 to 4.4.0 Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.3.4 to 4.4.0. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@0b2256b...5076954) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * enh(clib):Remove basic/interruption_error (#1650) * Add pb_neb_lib dependencies to centenginestats * Add pb_bam_lib dependencies to engine_legacy_conf REFS: MON-147186 * no engine_otl_endpoint parameter in telegraf config (#1676) * fix(common/engine_conf): multiple inheritence broken because of a mis… (#1680) * fix(common/engine_conf): multiple inheritence broken because of a missing flag enabled * fix(common/log_v2): segfault in centengine fixed * fix(engine/config/applier): bad use of std::equal * fix(tests/engine): new test * fix(broker/neb): cbmod was linked with not needed libraries * fix(broker/lua): a memory leak introduced with the new openssl md5 fixed * fix(tests/engine): a new test to validate the good behavior of inheritance * enh(cmake): new option LEGACY_ENGINE to compile the legacy engine instead of the new one * fix(gh/alma8): maxscale repo is disabled on alma8 * fix(cmake): issues with dependencies * enh(gha): new possibility to save packages as artifacts REFS: MON-147499 * enh(ci): run promote job in dry-run mode on testing branches (#1691) * MON 137835 cma windows robot tests (#1555) * add wsl robot test * fix(engine): host's name instead of template name as alias (#1690) * (fix(engine): host's name instead of template name as alias * fix(Engine): review code REFS: MON-16261 * fix(ci): check PR status from head branch name (#1707) * fix(broker/bbdo):grpc_stream.proto is bad generated (#1713) * fix(broker/bbdo):grpc_stream.proto is bad generated * fix(broker/bbdo): review code REFS: MON- 147911 * fix(ci): legacy conf engine enabled * enh(ci): detect automatically cloud versions (#1712) * fix(broker/neb): fix bbdov2 hostgroup to correctly set enabled flag (#1720) We were not looking for the correct nebtype for updates. * MON-148688-telegraf-certificate-parameters-harmonization (#1716) REFS:MON-148688 * Mon 131997 cma telegraf whitelist (#1723) * telegraf conf_server sues conf_helper * whitelist implementation * add whitelist test * add whitelist test * installer (#1715) dlg and files installer agent is a windows service add agent version resources first version of installer writer review add installer to CMakeLists.txt add comments Apply suggestions from code review Co-authored-by: sechkem <sechkem@ext.centreon.com> Co-authored-by: cg-tw <83637804+cg-tw@users.noreply.github.com> * chore(deps): bump actions/upload-artifact from 4.3.4 to 4.4.0 Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.3.4 to 4.4.0. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@0b2256b...5076954) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: sechkem <sechkem@ext.centreon.com> Co-authored-by: jean-christophe81 <98889244+jean-christophe81@users.noreply.github.com> Co-authored-by: David Boucher <dboucher@centreon.com> Co-authored-by: Kevin Duret <kduret@centreon.com> Co-authored-by: Vincent Untz <vuntz@centreon.com> Co-authored-by: cg-tw <83637804+cg-tw@users.noreply.github.com> Co-authored-by: Paul Oureib <poureib@centreon.com> * remove excessive checkouts * fix checkout that was needed after all --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: sechkem <sechkem@ext.centreon.com> Co-authored-by: jean-christophe81 <98889244+jean-christophe81@users.noreply.github.com> Co-authored-by: David Boucher <dboucher@centreon.com> Co-authored-by: Kevin Duret <kduret@centreon.com> Co-authored-by: Vincent Untz <vuntz@centreon.com> Co-authored-by: cg-tw <83637804+cg-tw@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…sing flag enabled
Description
Inheritence broken because the 'changed' flag is not updated while applying templates.