Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gorgone-mbi): wrong order execution for events calculation #1692

Draft
wants to merge 12 commits into
base: develop
Choose a base branch
from
Draft

fix(gorgone-mbi): wrong order execution for events calculation #1692

wants to merge 12 commits into from

Conversation

garnier-quentin
Copy link
Contributor

Description

There is a race condition with rebuild. Some tables are filled before the the DROP/CREATE.

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 22.04.x
  • 22.10.x
  • 23.04.x
  • 23.10.x
  • 24.04.x
  • master

How this pull request can be tested ?

It's a race condition so it's kind of difficult to reproduce. You can test the rebuild is still working.

Checklist

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have made corresponding changes to the documentation.
  • I have rebased my development branch on the base branch (master, maintenance).

sechkem and others added 8 commits September 5, 2024 09:13
@sechkem
enh(clib):Remove basic/interruption_error (centreon#1650)
cb70ed3 
* Add pb_neb_lib dependencies to centenginestats
* Add pb_bam_lib dependencies to engine_legacy_conf

REFS: MON-147186
@jean-christophe81
no engine_otl_endpoint parameter in telegraf config (centreon#1676)
d883265
@kduret
fix(packaging): add dependency to perl(lib) (centreon#1681)
45a726c
@bouda1
fix(common/engine_conf): multiple inheritence broken because of a mis… (
2810e5a 
centreon#1680)

* fix(common/engine_conf): multiple inheritence broken because of a missing flag enabled
* fix(common/log_v2): segfault in centengine fixed
* fix(engine/config/applier): bad use of std::equal
* fix(tests/engine): new test
* fix(broker/neb): cbmod was linked with not needed libraries
*  fix(broker/lua): a memory leak introduced with the new openssl md5 fixed
* fix(tests/engine): a new test to validate the good behavior of inheritance
* enh(cmake): new option LEGACY_ENGINE to compile the legacy engine instead of the new one
* fix(gh/alma8): maxscale repo is disabled on alma8
* fix(cmake): issues with dependencies
* enh(gha): new possibility to save packages as artifacts

REFS: MON-147499
fix(gorgone-mbi): wrong order execution for events calculation
adc5000
fix(gorgone-mbi): wrong order execution for events calculation
9d2a775
fix(gorgone-mbi): wrong order execution for events calculation
6ad8fe6
fix(gorgone-mbi): wrong order execution for events calculation
4830554
@garnier-quentin garnier-quentin requested a review from a team as a code owner September 12, 2024 13:11
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 12, 2024 •
edited
Loading

Important

Review skipped

Auto reviews are limited to specific labels.

Labels to auto review (1)
  • coderabbit

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@garnier-quentin garnier-quentin mentioned this pull request Sep 19, 2024
Closed
10 tasks
@y-kacher
Copy link

y-kacher commented Sep 23, 2024 •
edited
Loading

Hi @garnier-quentin,

Indeed, thanks for the performance enhancements, it avoids multiple requests to the db. It would be perfect if you could add a message like below :

[WARNING] The service template with id = 2701 inherits the template ID = 2702 more than once, please check relations of the template with ID = 2701!

Or before exiting the function (to avoid too much log writing):

[WARNING] The service template loop detected !

@bouda1 bouda1 requested review from a team as code owners September 25, 2024 08:14
@kduret kduret marked this pull request as draft December 13, 2024 10:36
@kduret
Copy link
Contributor

kduret commented Dec 13, 2024

I moved it as draft until conflicts are resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuntoja tuntoja tuntoja approved these changes

@lucie-dubrunfaut lucie-dubrunfaut Awaiting requested review from lucie-dubrunfaut lucie-dubrunfaut is a code owner automatically assigned from centreon/owners-perl

@Evan-Adam Evan-Adam Awaiting requested review from Evan-Adam Evan-Adam is a code owner automatically assigned from centreon/owners-robot-e2e

@ddes ddes Awaiting requested review from ddes ddes is a code owner automatically assigned from centreon/owners-pipelines

@mushroomempires mushroomempires Awaiting requested review from mushroomempires mushroomempires is a code owner automatically assigned from centreon/owners-pipelines

@jean-christophe81 jean-christophe81 Awaiting requested review from jean-christophe81 jean-christophe81 is a code owner automatically assigned from centreon/owners-cpp

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@garnier-quentin @y-kacher @kduret @tuntoja @sechkem @jean-christophe81 @bouda1