fix(scope): metric names not escaped graphite 24.04 #1858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bouda1
requested review from
sdepassio,
smau-centreon,
lucie-dubrunfaut,
kduret,
tuntoja and
jean-christophe81
|
Important Review skippedAuto reviews are limited to specific labels. 🏷️ Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
kduret
reviewed
Dec 6, 2024
| @@ -221,7 +221,7 @@ jobs: | |||
| run: rm -rf *-debuginfo*.${{ matrix.package_extension }} | |||
|
|
|||
| # set condition to true if artifacts are needed | |||
| - if: ${{ false }} | |||
| - if: ${{ true }} | |||
There was a problem hiding this comment.
Suggested change
| - if: ${{ true }} | |
| - if: ${{ false }} |
tuntoja
changed the title
tuntoja
approved these changes
Dec 9, 2024
… (#1954) * enh(broker/grpc): Improvement of the grpc python generator script * enh(tests): new test on downtimes, to check duplicates in rrd * enh(broker): AdaptiveHostStatus and AdaptiveServiceStatus added * fix(engine): update_status() generalized with an argument * fix(broker): neb::callbacks works better with service_type and internal_id * enh(broker/lua): the lua stream must handle AdaptiveHostStatus and AdaptiveServiceStatus * enh(broker/unified_sql): work on adaptive status in unified_sql * cleanup(collect): headers removed when not needed * enh(cmake): cmake-vcpkg improved * fix(broker/bam): pb_adaptive_service_status are handled by bam now REFS: MON-151251
bouda1
force-pushed
the
MON-152669-metric_names_not_escaped_graphite_24.04
branch
from
235a07c to
291bcc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Metric names should be escaped now.
REFS: MON-152669