[Alarm] Alarm page view #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage remained the same at 100.0% when pulling b7f1d20205e9fde5bba530e9871ae71707dfa3b3 on alarm-page into 1b54830 on dev. |
|
這截圖怎麼感覺不太一樣 |
CApopsicle
force-pushed
the
alarm-page
branch
2 times, most recently
from
64ea84d to
0c2e72e
Compare
|
Coverage remained the same at 100.0% when pulling 0c2e72e6138d2e82c04973df2dfa462bfa698262 on alarm-page into 1b54830 on dev. |
CApopsicle
force-pushed
the
alarm-page
branch
from
0c2e72e to
f1a7e67
Compare
rwu823
reviewed
Jan 3, 2017
src/containers/alarm/index.js
Outdated
| <Tab.Content slot="tabContent" name="profile"> | ||
| <div> | ||
| <div class={[s.wrapper]}></div> | ||
| <Grid { ...{ props } } /> |
There was a problem hiding this comment.
這邊怎麼不直接 ...{ props: alarmPage } 就好 @@?
chuanxd
reviewed
Jan 4, 2017
| .opeartionInline { | ||
| display: flex; | ||
| align-items: baseline; | ||
| .opeartions { |
There was a problem hiding this comment.
有用 css module 我認為可以把 css class selector 扁平化
Dsweih
force-pushed
the
alarm-page
branch
2 times, most recently
from
401956f to
dc0f315
Compare
Codecov Report
@@ Coverage Diff @@
## dev #13 +/- ##
===================================
Coverage 100% 100%
===================================
Files 2 2
Lines 40 40
Branches 14 14
===================================
Hits 40 40Continue to review full report at Codecov.
|
Dsweih
force-pushed
the
alarm-page
branch
5 times, most recently
from
a50178e to
4f4fac2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/alarmpage api not readycc @rwu823 @chuanxd
This change is