Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbd: rename groupNamePrefix to volumeGroupNamePrefix #5063

Merged

Conversation

iPraveenParihar
Copy link
Contributor

@iPraveenParihar iPraveenParihar commented Jan 9, 2025

Describe what this PR does

CephFS uses the parameter volumeGroupNamePrefix for creating VolumeGroups.
This commit renames groupNamePrefix to volumeGroupNamePrefix for RBD
VolumeGroup creation to ensure consistent naming.

See - #4750 (comment)

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next major release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

Show available bot commands

These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:

  • /retest ci/centos/<job-name>: retest the <job-name> after unrelated
    failure (please report the failure too!)

@iPraveenParihar iPraveenParihar added enhancement New feature or request component/rbd Issues related to RBD labels Jan 9, 2025
@iPraveenParihar iPraveenParihar self-assigned this Jan 9, 2025
@iPraveenParihar iPraveenParihar changed the title Rename/group name prefix param name rbd: rename groupNamePrefix to volumeGroupNamePrefix Jan 9, 2025
@mergify mergify bot added the bug Something isn't working label Jan 9, 2025
@iPraveenParihar iPraveenParihar marked this pull request as ready for review January 9, 2025 07:32
@nixpanic nixpanic added the backport-to-release-v3.13 Label to backport from devel to release-v3.13 branch label Jan 9, 2025
@nixpanic
Copy link
Member

nixpanic commented Jan 9, 2025

@Mergifyio queue

Copy link
Contributor

mergify bot commented Jan 9, 2025

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at c2fff75

CephFS uses the parameter `volumeGroupNamePrefix` for creating VolumeGroups.
This commit renames `groupNamePrefix` to `volumeGroupNamePrefix` for RBD
VolumeGroup creation to ensure consistent naming.

Signed-off-by: Praveen M <m.praveen@ibm.com>
Signed-off-by: Praveen M <m.praveen@ibm.com>
@iPraveenParihar iPraveenParihar force-pushed the rename/groupName-prefix-param-name branch from 8012d02 to 2fa5d19 Compare January 9, 2025 09:55
@mergify mergify bot added the ok-to-test Label to trigger E2E tests label Jan 9, 2025
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.32

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.32

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.32

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Jan 9, 2025
@mergify mergify bot merged commit c2fff75 into ceph:devel Jan 9, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-release-v3.13 Label to backport from devel to release-v3.13 branch bug Something isn't working component/rbd Issues related to RBD enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants