rocksdb-resharding: add a retry/until #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guits
force-pushed
the
sync_orch_ps_rocksdb-resharding_playbook
branch
from
9139093 to
e57a9d2
Compare
asm0deuz
force-pushed
the
sync_orch_ps_rocksdb-resharding_playbook
branch
2 times, most recently
from
2e2aed6 to
9e0df31
Compare
When retrieving the container_image, if the corresponding OSD
isn't running (not started/ready yet), let's retry during 120sec before
we let the playbook fail.
This is because of a failure seen in the CI like following:
```
TASK [get container image currently used by osd container] *********************
task path: /home/jenkins-build/build/workspace/cephadm-ansible-prs-el8-functional/rocksdb-resharding.yml:66
Monday 13 June 2022 15:20:38 +0000 (0:00:00.015) 0:00:00.683 ***********
ok: [localhost -> ceph-node0] => changed=false
cmd:
- cephadm
- shell
- ceph
- orch
- ps
- --daemon_type
- osd
- --daemon_id
- '0'
- --format
- json
delta: '0:00:02.669373'
end: '2022-06-13 15:20:42.149214'
rc: 0
start: '2022-06-13 15:20:39.479841'
stderr: |-
Inferring fsid 4217f198-b8b7-11eb-941d-5254004b7a69
Inferring config /var/lib/ceph/4217f198-b8b7-11eb-941d-5254004b7a69/mon.ceph-node0/config
Using ceph image with id '7d10b4103611' and tag 'master' created on 2022-05-23 21:52:02 +0000 UTC
quay.ceph.io/ceph-ci/ceph@sha256:0ece388ce186bf2122eb4f3389d6b108fa94aa3541d40d08449286fffc34e29f
stderr_lines: <omitted>
stdout: |2-
[{"daemon_id": "0", "daemon_name": "osd.0", "daemon_type": "osd", "events": ["2022-06-13T15:20:20.821851Z daemon:osd.0 [INFO] \"Deployed osd.0 on host 'ceph-node4'\""], "hostname": "ceph-node4", "is_active": false, "memory_request": 4294967296, "ports": [], "service_name": "osd.osd", "status": 2, "status_desc": "starting"}]
stdout_lines: <omitted>
```
We can see the 'status_desc' is 'starting'.
Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
asm0deuz
force-pushed
the
sync_orch_ps_rocksdb-resharding_playbook
branch
from
9e0df31 to
5743d5b
Compare
This was referenced Nov 23, 2023
asm0deuz
added a commit
that referenced
this pull request
Nov 23, 2023
rocksdb-resharding: add a retry/until (backport #107)
asm0deuz
added a commit
that referenced
this pull request
Nov 23, 2023
rocksdb-resharding: add a retry/until (backport #107)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When retrieving the container_image, if the corresponding OSD
isn't running (not started/ready yet), let's retry during 120sec before
we let the playbook fail.
This is because of a failure seen in the CI like following:
We can see the 'status_desc' is 'starting'.
Signed-off-by: Guillaume Abrioux gabrioux@redhat.com