cephadm-boostrap: add new boostrap parameters #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guits
reviewed
Feb 15, 2024
guits
reviewed
Feb 15, 2024
Comment on lines
+305
to
+315
| # Build cephadm with parameters | ||
| cmd = extend_append('cephadm', cephadm_params) | ||
| # Extends with boostrap parameters | ||
| cmd.extend(extend_append('bootstrap', cephadm_bootstrap_params)) |
guits
reviewed
Feb 15, 2024
guits
approved these changes
Feb 15, 2024
Added a list of boostrap parameters related to IBM call home and HW monitoring feature only available downstream Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2246266 Signed-off-by: Teoman ONAY <tonay@ibm.com>
asm0deuz
force-pushed
the
bootstrap_downstream_params
branch
from
fdd5f89 to
faa7b2f
Compare
This was referenced Feb 15, 2024
asm0deuz
added a commit
that referenced
this pull request
Feb 15, 2024
cephadm-boostrap: add new boostrap parameters (backport #276)
asm0deuz
added a commit
that referenced
this pull request
Feb 15, 2024
cephadm-boostrap: add new boostrap parameters (backport #276)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a list of boostrap parameters related to IBM call home and HW monitoring feature only available downstream
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2246266