fixed conditionals for installing prerequisites, added lvm2 to prerequisites #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
droidben
changed the title
|
@droidben Please sign-off your commits. |
|
@asm0deuz Is extended commit message enough or do I need to sign with GPG? |
Signed-off-by: droidben <9570377+droidben@users.noreply.github.com>
…al docs Signed-off-by: droidben <9570377+droidben@users.noreply.github.com>
|
Added commits signed with gpg now |
…al docs Signed-off-by: droidben <9570377+droidben@users.noreply.github.com>
Signed-off-by: droidben <9570377+droidben@users.noreply.github.com>
…al docs Signed-off-by: Ben Dätwyler <ben.daetwyler@bendroid.ch>
Signed-off-by: Ben Dätwyler <ben.daetwyler@bendroid.ch>
|
hi @droidben thanks for your contribution Can you elaborate on what you are trying to achieve here? (it's one of the reason a commit message is always welcome by the way). Initially you had 2 commits but you have 11 commits in your branch, please can you clean it up? having the signed-off line in your commit message is enough, we are not requiring any gpg signatures here. Regards |
|
I will delete this PR and open a new one with the original commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the prerequisites conditionals were incorrect
Also as per the official docs lvm2 is a prerequisite, so I added it to the infra packages