Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: use maintained github.com/aws/aws-sdk-go-v2 module instead of v1 #1057

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nixpanic
Copy link
Member

@nixpanic nixpanic commented Jan 7, 2025

github.com/aws/aws-sdk-go is deprecated and will be end-of-life later in
2025. github.com/aws/aws-sdk-go-v2 is the replacement, but using it
requires a few minor adaptions.

Also update the go version in go.mod, as go1.19 is not supported anymore, and certain packages (at least
aws-sdk-go-v2) require go1.21 or newer.

Closes: #1053

@phlogistonjohn
Copy link
Collaborator

Would it be a big pain to either split the PR or reorganize it so that the Go 1.21 changes come first (and are combined)? That way we'd be more future bisect friendly. (this is my exception to the rule that patches should be as small as reasonably possible )

I'm assuming that the new aws library requires the change to the go <ver> line of the Go file?

@nixpanic
Copy link
Member Author

nixpanic commented Jan 9, 2025

Would it be a big pain to either split the PR or reorganize it so that the Go 1.21 changes come first (and are combined)? That way we'd be more future bisect friendly. (this is my exception to the rule that patches should be as small as reasonably possible )

Sure, I can do that.

I'm assuming that the new aws library requires the change to the go <ver> line of the Go file?

That is my assumption as well. Evey time I undid the change, it popped up after running make test-container.

@phlogistonjohn
Copy link
Collaborator

Would it be a big pain to either split the PR or reorganize it so that the Go 1.21 changes come first (and are combined)? That way we'd be more future bisect friendly. (this is my exception to the rule that patches should be as small as reasonably possible )

Sure, I can do that.

TY!

I'm assuming that the new aws library requires the change to the go <ver> line of the Go file?

That is my assumption as well. Evey time I undid the change, it popped up after running make test-container.

OK. Thanks for verifying!

go1.19 is not supported anymore, and certain packages (at least
aws-sdk-go-v2) require go1.21 or newer.

Revive complains about the use of `max` as variable name. go1.21
contains the `max()` function, so it is better to rename the variable.

Signed-off-by: Niels de Vos <ndevos@ibm.com>
github.com/aws/aws-sdk-go is deprecated and will be end-of-life later in
2025. github.com/aws/aws-sdk-go-v2 is the replacement, but using it
requires a few minor adaptions.

Closes: ceph#1053
Signed-off-by: Niels de Vos <ndevos@ibm.com>
@nixpanic
Copy link
Member Author

nixpanic commented Jan 9, 2025

@phlogistonjohn is this sortof how you were expecting it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-sdk-go is deprecated
2 participants