-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): CDB-2128 Address nonce errors #1004
Open
dbcfd
wants to merge
4
commits into
develop
Choose a base branch
from
cdb-2128-nonce-error
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,50 +16,53 @@ function buildExpressMiddleware() { | |
* Notice that the absense of a did header or body bypasses any checks below | ||
* this app will still work if the logice above is not in place. | ||
*/ | ||
return function(req: Request, _res: Response, next: NextFunction) { | ||
if (req.headers) { | ||
if (req.headers['did'] && req.body) { | ||
if (Object.keys(req.body).length > 0) { | ||
const digest = buildBodyDigest(req.headers['content-type'], req.body) | ||
if (req.headers['digest'] == digest) { | ||
return next() | ||
} else { | ||
throw Error('Body digest verification failed') | ||
} | ||
} | ||
} | ||
return function (req: Request, _res: Response, next: NextFunction) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Prettier |
||
if (req.headers) { | ||
if (req.headers['did'] && req.body) { | ||
if (Object.keys(req.body).length > 0) { | ||
const digest = buildBodyDigest(req.headers['content-type'], req.body) | ||
if (req.headers['digest'] == digest) { | ||
return next() | ||
} else { | ||
throw Error('Body digest verification failed') | ||
} | ||
} | ||
return next() | ||
} | ||
} | ||
return next() | ||
} | ||
} | ||
|
||
function buildBodyDigest(contentType: string | undefined, body: any): string | undefined { | ||
if (!body) return | ||
if (!body) return | ||
|
||
let hash: Uint8Array | undefined | ||
let hash: Uint8Array | undefined | ||
|
||
if (contentType) { | ||
if (contentType.includes('application/vnd.ipld.car')) { | ||
const carFactory = new CARFactory() | ||
carFactory.codecs.add(DAG_JOSE) | ||
console.log('Will build a car file from req.body', body) | ||
try { | ||
console.log('Will build a car file from req.body (as utf8 string)', u8a.toString(body, 'base64')) | ||
} catch(e) { | ||
console.log('Couldn\'t convert req.body to string: ', e) | ||
} | ||
const car = carFactory.fromBytes(body) | ||
if (!car.roots[0]) throw Error('Missing CAR root') | ||
return car.roots[0].toString() | ||
} else if (contentType.includes('application/json')) { | ||
hash = sha256.hash(u8a.fromString(JSON.stringify(body))) | ||
if (contentType) { | ||
if (contentType.includes('application/vnd.ipld.car')) { | ||
const carFactory = new CARFactory() | ||
carFactory.codecs.add(DAG_JOSE) | ||
console.log('Will build a car file from req.body', body) | ||
try { | ||
console.log( | ||
'Will build a car file from req.body (as utf8 string)', | ||
u8a.toString(body, 'base64') | ||
) | ||
} catch (e) { | ||
console.log("Couldn't convert req.body to string: ", e) | ||
} | ||
} | ||
|
||
if (!hash) { | ||
// Default to hashing stringified body | ||
const car = carFactory.fromBytes(body) | ||
if (!car.roots[0]) throw Error('Missing CAR root') | ||
return car.roots[0].toString() | ||
} else if (contentType.includes('application/json')) { | ||
hash = sha256.hash(u8a.fromString(JSON.stringify(body))) | ||
} | ||
} | ||
|
||
return `0x${u8a.toString(hash, 'base16')}` | ||
if (!hash) { | ||
// Default to hashing stringified body | ||
hash = sha256.hash(u8a.fromString(JSON.stringify(body))) | ||
} | ||
|
||
return `0x${u8a.toString(hash, 'base16')}` | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,9 +15,11 @@ export class CeramicAnchorServer extends Server { | |
super(true) | ||
|
||
this.app.set('trust proxy', true) | ||
this.app.use(bodyParser.raw({inflate: true, type: 'application/vnd.ipld.car'})) | ||
this.app.use(bodyParser.raw({ inflate: true, type: 'application/vnd.ipld.car' })) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Prettier |
||
this.app.use(bodyParser.json({ type: 'application/json' })) | ||
this.app.use(bodyParser.urlencoded({ extended: true, type: 'application/x-www-form-urlencoded' })) | ||
this.app.use( | ||
bodyParser.urlencoded({ extended: true, type: 'application/x-www-form-urlencoded' }) | ||
) | ||
this.app.use(expressLoggers) | ||
if (config.requireAuth == true) { | ||
this.app.use(auth) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prettier