Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle subgraph template create when filterLogsByAddresses set to true #447

Merged
merged 3 commits into from
Nov 3, 2023
Merged

Handle subgraph template create when filterLogsByAddresses set to true #447

merged 3 commits into from
Nov 3, 2023

Conversation

nikugogoi
Copy link
Collaborator

@nikugogoi nikugogoi commented Nov 2, 2023 •
edited
Loading

Part of Block processing optimizations

  • Refetch logs in events processing when filterLogsByAddresses flag is set to true
  • Add constant HISTORICAL_MAX_FETCH_AHEAD to avoid fetching too many blocks ahead of events processing
  • TODOs to be fulfilled in follow on PRs:
    • Wait for events processing to complete before moving ahead with historical processing for further blocks
    • Make HISTORICAL_MAX_FETCH_AHEAD configurable
    • Handle template create in non subgraph order of events processing

@nikugogoi nikugogoi self-assigned this Nov 2, 2023
@nikugogoi nikugogoi changed the title [WIP] Handle subgraph template create when filterLogsByAddresses set to true Handle subgraph template create when filterLogsByAddresses set to true Nov 3, 2023
@ashwinphatak ashwinphatak merged commit 0d7e3dd into main Nov 3, 2023
2 checks passed
@ashwinphatak ashwinphatak deleted the ng-address-filter-template branch November 3, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikugogoi nikugogoi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikugogoi @ashwinphatak