docs(tagline): modify docs to verify component #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billhimmelsbach
requested review from
meissadia and
shindigira
as code owners
✅ Deploy Preview for cfpb-design-system-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
I didn't mark this as "verified" in this PR, since I'm not sure if we have an official stamp of approval process yet, so I'll hold off till at least we chat about it at the sync. |
meissadia
approved these changes
Oct 19, 2023
meissadia
pushed a commit
that referenced
this pull request
Oct 26, 2023
I went through and [verified the Tagline component](#205) as part of the work on the banner component. Only small changes to the documentation appear to be needed. I didn't add the deprecated "Extra large tagline" story from the design system, since it was deprecated and all, but we can chat about that at the DSR sync. ## Changes - add component description - remove heading - change stories to sentence case ## How to test this PR 1. Take a peek at the DSR and see how it looks ## Screenshots  ## Notes I didn't mark this component as "verified" in this PR, since I'm not sure if we have an official stamp of approval process yet, so I'll hold off till at least we chat about it at the sync.
21 tasks
This was referenced Nov 2, 2023
This was referenced Nov 3, 2023
billhimmelsbach
added a commit
that referenced
this pull request
Nov 7, 2023
Resolves #205 # Final Design Review of Tagline Component  [Link to Tagline Component in this PR](https://deploy-preview-218--cfpb-design-system-react.netlify.app/?path=/docs/components-verified-taglines--overview) Previous work on component: #207
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went through and verified the Tagline component as part of the work on the banner component. Only small changes to the documentation appear to be needed. I didn't add the deprecated "Extra large tagline" story from the design system, since it was deprecated and all, but we can chat about that at the DSR sync.
Changes
How to test this PR
Screenshots
Notes
I didn't mark this component as "verified" in this PR, since I'm not sure if we have an official stamp of approval process yet, so I'll hold off till at least we chat about it at the sync.