Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Prototype] User profile pages #210

Closed
wants to merge 6 commits into from
Closed

Conversation

meissadia
Copy link
Contributor

@meissadia meissadia commented Oct 20, 2023

Closes #208

How to test this PR

  1. Visit the full page preview to view the Complete your user profile form
  2. Click Submit to visit the User profile submissions status page
  3. Click Proceed to filing platform to navigate back to the initial page

TODO

  • Code organization: I think because of where the files live (/stories/ directory) the importing/exporting is handled differently by Storybook, hence the reason everything is in a single file. Might need to move things to /components/Prototypes/* to support code splitting.
  • Map UI elements to DSR / DS components
    • Open tickets to create missing components from TODO # 2

Screenshots

Complete profile Profile status
screencapture-deploy-preview-210-cfpb-design-system-react-netlify-app-iframe-html-2023-10-20-13_03_34 screencapture-deploy-preview-210-cfpb-design-system-react-netlify-app-iframe-html-2023-10-20-13_03_20

@netlify
Copy link

netlify bot commented Oct 20, 2023

Deploy Preview for cfpb-design-system-react failed.

Name Link
🔨 Latest commit 73e4e4f
🔍 Latest deploy log https://app.netlify.com/sites/cfpb-design-system-react/deploys/6578a2d9868d0e0008a941a4

@meissadia meissadia changed the title WIP: Complete Profile -> Profile status [Prototype] User profile pages Oct 20, 2023
@meissadia meissadia force-pushed the 208-prototype-user-profile branch 2 times, most recently from 92b6f3a to 81b7e4d Compare October 23, 2023 21:35
@meissadia
Copy link
Contributor Author

Code refactored to break elements down into separate components. Also to highlight DSR vs SBL components.

@billhimmelsbach billhimmelsbach self-requested a review October 24, 2023 15:38
@billhimmelsbach
Copy link
Contributor

Heyo @meissadia! I added myself as a reviewer.

@meissadia meissadia force-pushed the 208-prototype-user-profile branch from 81b7e4d to b975085 Compare October 24, 2023 17:58
@billhimmelsbach billhimmelsbach removed their request for review November 2, 2023 14:40
@billhimmelsbach
Copy link
Contributor

Great to see this in the app!

@meissadia meissadia deleted the 208-prototype-user-profile branch February 12, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Prototype] User Profile page in Storybook
3 participants