Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Link] Address issues identified during the verification process #217

Merged
merged 7 commits into from
Oct 31, 2023

Conversation

meissadia
Copy link
Contributor

@meissadia meissadia commented Oct 25, 2023

Link to #215

Changes

  • Sync story content with DS
  • Add unit tests

How to test this PR

  1. yarn vitest Link

Notes

  • Accessibility issue with the Icon component, which is used in some of the Link stories, due to missing alt text. I think this issue should be addressed as part of the Icon component's verification process.

Screenshots

screencapture-localhost-6006-2023-10-25-10_56_10

@meissadia meissadia requested a review from shindigira as a code owner October 25, 2023 16:53
@netlify
Copy link

netlify bot commented Oct 25, 2023

Deploy Preview for cfpb-design-system-react ready!

Name Link
🔨 Latest commit efcad7b
🔍 Latest deploy log https://app.netlify.com/sites/cfpb-design-system-react/deploys/65413429559ce100082f021f
😎 Deploy Preview https://deploy-preview-217--cfpb-design-system-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@meissadia meissadia linked an issue Oct 25, 2023 that may be closed by this pull request
21 tasks
@meissadia meissadia removed a link to an issue Oct 25, 2023
21 tasks
@meissadia meissadia linked an issue Oct 25, 2023 that may be closed by this pull request
21 tasks
Copy link
Contributor

@billhimmelsbach billhimmelsbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@meissadia meissadia enabled auto-merge (squash) October 31, 2023 17:07
@meissadia meissadia merged commit a88bf52 into main Oct 31, 2023
5 checks passed
@meissadia meissadia deleted the 214-verify-links branch October 31, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Verify Links Component
2 participants