Update to yarn@4.2.1 | Add offline cache #337
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anselmbradford
requested review from
meissadia,
shindigira and
billhimmelsbach
as code owners
✅ Deploy Preview for cfpb-design-system-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
anselmbradford
changed the title
shindigira
added a commit
that referenced
this pull request
May 13, 2024
closes #342 ## Note - Includes fixes from #337 to pass the Netlify build tests ## Changes - accessibility(pagination): button icons enable isPresentational to be ignored - styling(pagination): button content is flex-centered. ## Screenshot <img width="955" alt="Screenshot 2024-05-09 at 6 15 14 PM" src="https://github.com/cfpb/design-system-react/assets/13324863/e0159f7d-67cd-421c-b284-d319c7143359"> --------- Co-authored-by: Ans <git@anselmbradford.com> Co-authored-by: Ans <anselmbradford@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #314
Patch updates yarn to 4.2.1
Also, since we have
enableGlobalCacheset tofalse, https://yarnpkg.com/features/caching#offline-mirror saysSo it looks like we shouldn't actually git ignore the cache and should add the cache here (similar to the old
npm-packages-offline-cache)Changes
How to test this PR
yarn installshould pass.