Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TextInput] Certain props should be optional #381

Merged
merged 5 commits into from
Oct 17, 2024
Merged

Conversation

tanner-ricks
Copy link
Contributor

@tanner-ricks tanner-ricks commented Oct 4, 2024

[Short description explaining the high-level reason for the pull request]

Changes

  • TextInput.tsx: Updated the property typing to fix an issue which caused properties that should be optional, to be considered mandatory instead.

How to test this PR

  1. View and verify the the deploy preview
  2. Pull 308-ts-error-fix
  3. Run yarn lint against the branch
  4. Verify that TextInput.tsx has no errors
  5. Run yarn test against the branch and verify that everything passes
  6. Build the package
  7. Update the package.json in sbl-frontend to include "design-system-react": "file:./<path-to-package.tgz>/package.tgz"
  8. Run yarn install
  9. Pull 986-default-max-length in sbl-frontend
  10. Verify that TextInput.tsx in sbl-frontend has no errors

Copy link

netlify bot commented Oct 4, 2024

Deploy Preview for cfpb-design-system-react ready!

Name Link
🔨 Latest commit 163d7e1
🔍 Latest deploy log https://app.netlify.com/sites/cfpb-design-system-react/deploys/670858ff20ce2c0008839d4f
😎 Deploy Preview https://deploy-preview-381--cfpb-design-system-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tanner-ricks tanner-ricks linked an issue Oct 4, 2024 that may be closed by this pull request
@tanner-ricks tanner-ricks changed the title Draft: [TextInput] Certain props should be optional [TextInput] Certain props should be optional Oct 9, 2024
@tanner-ricks tanner-ricks marked this pull request as ready for review October 9, 2024 17:50
Copy link
Contributor

@meissadia meissadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏾

@tanner-ricks tanner-ricks merged commit 7cfc2c1 into main Oct 17, 2024
8 of 10 checks passed
@tanner-ricks tanner-ricks deleted the 308-ts-error-fix branch October 17, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TextInput] Certain props should be optional
2 participants