Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(alert): no wrapper class when no message provided #389

Merged

Conversation

billhimmelsbach
Copy link
Contributor

Currently when there's no message but has children (explanations), then a m-notification_explanation applied which makes it not possible to achieve designs like these (unbolded, aligned text):

Screenshot 2024-11-19 at 4 13 26 PM Screenshot 2024-11-19 at 4 16 46 PM

Changes

  • if there is no message, but still has children then do not apply m-notification_explanation to allow alert flexibility

How to test this PR

  1. Do the tests pass?
  2. How do the examples look?
  3. Try modifying the package.json to point the DSR to this commit and see how the alerts are affected.

Screenshots

Screenshot 2024-11-19 at 4 21 12 PM

@billhimmelsbach billhimmelsbach requested review from tanner-ricks and removed request for ojbravo November 19, 2024 21:21
Copy link

netlify bot commented Nov 19, 2024

Deploy Preview for cfpb-design-system-react ready!

Name Link
🔨 Latest commit bc21906
🔍 Latest deploy log https://app.netlify.com/sites/cfpb-design-system-react/deploys/673d0671fd11fe0008e45039
😎 Deploy Preview https://deploy-preview-389--cfpb-design-system-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

meissadia
meissadia previously approved these changes Nov 19, 2024
Copy link
Contributor

@meissadia meissadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍🏾

Co-authored-by: Meis <meissadia@gmail.com>
@billhimmelsbach billhimmelsbach merged commit 87e95f8 into main Nov 20, 2024
8 of 10 checks passed
@billhimmelsbach billhimmelsbach deleted the 21-alerts-without-messages-centered-and-not-bold branch November 20, 2024 15:32
@billhimmelsbach billhimmelsbach restored the 21-alerts-without-messages-centered-and-not-bold branch November 20, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants