Skip to content

Commit

Permalink
Linting fixes that are different in github than in our local poetry r…
Browse files Browse the repository at this point in the history
…uns.
  • Loading branch information
jcadam14 committed Jan 2, 2024
1 parent fcaba8b commit d2869fc
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 6 deletions.
6 changes: 2 additions & 4 deletions regtech_data_validator/phase_validations.py
Original file line number Diff line number Diff line change
Expand Up @@ -1231,14 +1231,12 @@ def get_phase_1_and_2_validations_for_lei(context: dict[str, str] | None = None)
),
severity=Severity.ERROR,
groupby="ct_credit_product",
conditions=[
{
conditions=[{
"condition_values": {"7", "8", "977"},
"is_equal_condition": False,
"target_value": "999",
"should_equal_target": True,
}
],
}],
),
],
},
Expand Down
4 changes: 2 additions & 2 deletions tests/test_csv_to_code_differences.py
Original file line number Diff line number Diff line change
Expand Up @@ -60,15 +60,15 @@ def test_csv_differences(self):
# Excel will strip that first single quote off when saving to a CSV, as it uses
# a starting single quote to signify that the rest of the data is a string.
# This checks if the description we're checking is one of those, and if it doesn't
# already start with a single quote in the CSV just in case someone saves the doc differently
# already start with a single quote in the CSV just in case someone saves the doc differently
# than with Excel
if row["validation_id"] in self.add_starting_quote and not row["description"].startswith("'"):
row["description"] = "'" + row["description"]
if (
row["type"].lower() != found_py_validation["type"].lower()
or row["description"] != found_py_validation["description"]
):
# This can be used locally to run a pytest and get a csv of discrepancies, which makes
# This can be used locally to run a pytest and get a csv of discrepancies, which makes
# for easier correcting of code/csv.
error_file.write(
f'{row["validation_id"]},{row["type"].lower()},{found_py_validation["type"].lower()},\"{row["description"]}\",\"{found_py_validation["description"]}\"\n'
Expand Down

0 comments on commit d2869fc

Please sign in to comment.