Added versions to the ruff and black linter actions #90
Conversation
jcadam14
requested review from
hkeeler,
guffee23,
lchen-2101 and
nargis-sultani
Coverage report
This PR does not seem to contain any modification to coverable code. |
There was a problem hiding this comment.
😕 This is annoying. I'm surprised these don't let you use whatever is in the local python environment, so it'd just use whatever is setup in poetry. But yeah, options seem like either latest or pinned versions. Makes me want to just run these commands ourselves and abandon these canned actions. But for now, yeah, I guess we just have to keep pyproject.toml and linters.yml in sync.
.github/workflows/linters.yml
Outdated
| ruff: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: chartboost/ruff-action@v1 | ||
| with: | ||
| version: 0.1.4 |
There was a problem hiding this comment.
This is now 0.1.15.
regtech-data-validator/pyproject.toml
Line 21 in 45bb608
There was a problem hiding this comment.
I've changed things up taking your annoyance (which I agree with). I changed the linters to instead do what the pytest does: installs poetry and runs poetry run black\ruff instead of relying on actions of said libraries. I put the linters into their own group in poetry so that the linter action can do poetry install --only linters (to keep from unnecessarily installing packages it doesn't need). Give a look over of those changes. This keeps everything running off of one poetry pyproject.toml instead of having versions in two different places.
If we're good with this, I can write stories for the other repos to switch to the same linting actions.
…rsions-for-black-and-ruff
Closes #89 Added versions to the linter actions. Since the pyproject.toml specifies distinct versions for each (instead of say ^24.1.0), I put the version equal to what is in the toml. Note that, as in the other stories referenced, the black linter supports the concept of capability versions. We're just not using itwith: version: 0.0.278here.
Closes #89
Added versions to the linter actions. Since the pyproject.toml specifies distinct versions for each (instead of say ^24.1.0), I put the version equal to what is in the toml. Note that, as in the other stories referenced, the black linter supports the concept of capability versions. We're just not using itwith:
version: 0.0.278here.