Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVL integration #295

Merged
merged 118 commits into from
Jun 13, 2024
Merged

AVL integration #295

merged 118 commits into from
Jun 13, 2024

Conversation

GBenedett
Copy link
Collaborator

@GBenedett GBenedett commented May 14, 2024

Create a new module called PyAVL with AVL inside

  • Add possibility to add and remove fuselage
  • Correct errors from check
  • Add ReadMe
  • Save single image (and change format?)
  • Redo Plot with matplotlib
  • Add installation script
  • Add Drag correction
  • Add test

@GBenedett GBenedett added Python Related to Python Stability AVL Related to AVL labels May 14, 2024
@GBenedett GBenedett self-assigned this May 14, 2024
Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 68.29653% with 201 lines in your changes missing coverage. Please review.

Project coverage is 62.75%. Comparing base (0741050) to head (7237a8f).
Report is 7 commits behind head on main.

Files Patch % Lines
ceasiompy/PyAVL/func/cpacs2avl.py 51.31% 166 Missing ⚠️
ceasiompy/PyAVL/func/avlconfig.py 79.45% 15 Missing ⚠️
ceasiompy/PyAVL/avlrun.py 84.44% 7 Missing ⚠️
ceasiompy/PyAVL/func/avlresults.py 93.25% 6 Missing ⚠️
ceasiompy/PyAVL/tests/test_avlconfig.py 91.66% 3 Missing ⚠️
ceasiompy/PyAVL/tests/test_avlresults.py 85.00% 3 Missing ⚠️
ceasiompy/PyAVL/func/rotation3D.py 95.23% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #295      +/-   ##
==========================================
+ Coverage   62.39%   62.75%   +0.35%     
==========================================
  Files          89       96       +7     
  Lines        8989     9602     +613     
==========================================
+ Hits         5609     6026     +417     
- Misses       3380     3576     +196     
Flag Coverage Δ
integrationtests 45.49% <64.29%> (+1.93%) ⬆️
unittests 51.24% <61.02%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator Author

@GBenedett GBenedett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@GBenedett GBenedett merged commit 1b7ff5c into main Jun 13, 2024
4 checks passed
@GBenedett GBenedett deleted the add_PyAVL branch June 13, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AVL Related to AVL Python Related to Python Stability
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants