object allocation: attribute_names and attributes_map #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subvertallchris
changed the title
|
This may fix #134, too. |
|
👍 |
subvertallchris
force-pushed
the
performance
branch
from
33b4c7e to
dea8ef2
Compare
|
👍 |
|
This should probably be modified to not change the output of |
|
This will be included in the next release. Thank you for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two things:
hash.keyscreates a new array each time it's called but that list doesn't change that often, so this hangs onto it.By making
attributes_mapa little uglier, we save one more array at the beginning and then another for each pairing of attribute and value! The overall object allocation improves performance, especially when a model has a large number of properties.