fix(runner): remove optional env variable from the requirements (#439)

Signed-off-by: Mattia Buccarella <m.buccarella@gmail.com>
chainloop-dev · Nov 15, 2023 · 90e1cc5 · 90e1cc5
1 parent a0e511a
commit 90e1cc5
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 3 deletions.
diff --git a/internal/attestation/crafter/runners/circleci_build.go b/internal/attestation/crafter/runners/circleci_build.go
@@ -43,7 +43,6 @@ func (r *CircleCIBuild) ListEnvVars() []string {
 
 		// Some info about the commit
 		"CIRCLE_BRANCH",
-		"CIRCLE_PR_NUMBER",
 
 		// Some info about the agent
 		"CIRCLE_NODE_TOTAL",

diff --git a/internal/attestation/crafter/runners/circleci_build_test.go b/internal/attestation/crafter/runners/circleci_build_test.go
@@ -92,7 +92,6 @@ func (s *circleCIBuildSuite) TestListEnvVars() {
 		"CIRCLE_BUILD_URL",
 		"CIRCLE_JOB",
 		"CIRCLE_BRANCH",
-		"CIRCLE_PR_NUMBER",
 		"CIRCLE_NODE_TOTAL",
 		"CIRCLE_NODE_INDEX",
 	}, s.runner.ListEnvVars())
@@ -123,7 +122,6 @@ var circleCIBuildTestingEnvVars = map[string]string{
 	"CIRCLE_BUILD_URL":  "http://some-build-url/",
 	"CIRCLE_JOB":        "some-job",
 	"CIRCLE_BRANCH":     "some-branch",
-	"CIRCLE_PR_NUMBER":  "1337",
 	"CIRCLE_NODE_TOTAL": "3",
 	"CIRCLE_NODE_INDEX": "1",
 }