Skip to content

Commit

Permalink
feat: do not validate crafting state server-side (#1724)
Browse files Browse the repository at this point in the history
Signed-off-by: Miguel Martinez <miguel@chainloop.dev>
  • Loading branch information
migmartri authored Jan 10, 2025
1 parent 497feb4 commit f5505a3
Show file tree
Hide file tree
Showing 5 changed files with 14 additions and 7 deletions.
5 changes: 3 additions & 2 deletions app/controlplane/api/controlplane/v1/attestation_state.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion app/controlplane/api/controlplane/v1/attestation_state.proto
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,8 @@ message AttestationStateServiceInitializedResponse {

message AttestationStateServiceSaveRequest {
string workflow_run_id = 1 [(buf.validate.field).string = {min_len: 1}];
attestation.v1.CraftingState attestation_state = 2 [(buf.validate.field).required = true];
// We do not want to validate its content since it might depend on the client-side schema
attestation.v1.CraftingState attestation_state = 2 [(buf.validate.field).ignore = IGNORE_ALWAYS];
// digest of the attestation state this update was performed on top of
// The digest might be empty the first time
string base_digest = 3;
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit f5505a3

Please sign in to comment.