Fix #6 and support for delete. #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deakjahn
commented
Jan 13, 2025
| @@ -46,6 +49,8 @@ data class SaveFileInfo(val filePath: String?, val fileData: ByteArray?, val fil | |||
| result = 31 * result + fileName.hashCode() | |||
| return result | |||
| } | |||
|
|
|||
| override fun toString() = "SaveFileInfo(filePath=$filePath fileName=$fileName)" | |||
There was a problem hiding this comment.
No need to dump a possibly large binary file into the log.
deakjahn
commented
Jan 13, 2025
| @@ -139,6 +144,7 @@ fun saveMultipleFiles( | |||
|
|
|||
| val begin = System.nanoTime() | |||
|
|
|||
| destinationSaveFilesInfo.clear() | |||
deakjahn
commented
Jan 13, 2025
| @@ -258,7 +259,7 @@ class Utils { | |||
| val saveFileNamePrefix: String = | |||
| destinationSaveFilesInfo.elementAt(index).saveFileNamePrefix | |||
| val documentFileNewFile = outputFolder!!.createFile( | |||
| sourceFileMimeType ?: "application/random", saveFileNamePrefix | |||
| sourceFileMimeType ?: "application/octet-stream", saveFileNamePrefix | |||
There was a problem hiding this comment.
There's no application/random, this one is the generic format.
deakjahn
commented
Jan 13, 2025
| @@ -341,7 +348,7 @@ class SaveFileInfo { | |||
| /// Required if [fileData] is provided. | |||
| final String? fileName; | |||
|
|
|||
| /// Create parameters for the [fileMetaData] method. | |||
| /// Create parameters for the [fileSaver] method. | |||
deakjahn
commented
Jan 13, 2025
| @@ -365,7 +372,7 @@ class SaveFileInfo { | |||
| // when using the print statement. | |||
| @override | |||
| String toString() { | |||
| return 'SaveFileInfo{filePath: $filePath, fileData: $fileData, fileName: $fileName}'; | |||
| return 'SaveFileInfo{filePath: $filePath, fileName: $fileName}'; | |||
There was a problem hiding this comment.
No need to dump a possibly large binary file into the log.
|
Thanks for the PR and the comments. I will review it soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll add a few review comments to describe individual changes.
The major one is adding support for deleting files, that's more or less obvious, copied and modified another command.