Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restart from local devfile should work even whem some attributes are empty #470

Merged
merged 4 commits into from
Jan 2, 2025

Conversation

vitaliy-guliy
Copy link
Contributor

@vitaliy-guliy vitaliy-guliy commented Dec 19, 2024

What does this PR do?

In a existing devworkspace object some attributes may have null values, we do not need to copy them to a new generated devfile.

What issues does this PR fix?

eclipse-che/che#23292

How to test this PR?

Does this PR contain changes that override default upstream Code-OSS behavior?

  • the PR contains changes in the code folder (you can skip it if your changes are placed in a che extension )
  • the corresponding items were added to the CHANGELOG.md file
  • rules for automatic git rebase were added to the .rebase folder

Signed-off-by: vitaliy-guliy <vgulyy@redhat.com>
Copy link

github-actions bot commented Dec 19, 2024

Click here to review and test in web IDE: Contribute

Copy link

Signed-off-by: vitaliy-guliy <vgulyy@redhat.com>
Copy link

Signed-off-by: vitaliy-guliy <vgulyy@redhat.com>
Copy link

Signed-off-by: vitaliy-guliy <vgulyy@redhat.com>
@vitaliy-guliy vitaliy-guliy changed the title [WIP] allow to restart from local devfile without copying attributes fix: restart from local devfile should work even whem some attributes are empty Jan 2, 2025
@vitaliy-guliy vitaliy-guliy marked this pull request as ready for review January 2, 2025 11:39
Copy link

github-actions bot commented Jan 2, 2025

@RomanNikitenko RomanNikitenko merged commit 98b032b into main Jan 2, 2025
7 checks passed
@RomanNikitenko RomanNikitenko deleted the debug-restart-from-local-devfile branch January 2, 2025 12:49
@devspacesbuild
Copy link

Build 3.19 :: code_3.x/1530: Console, Changes, Git Data

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

Build 3.19 :: code_3.x/1530: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/8445 triggered

@devspacesbuild
Copy link

@devspacesbuild
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants