Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure to send message still shows "success" #2

Open
thbar opened this issue Dec 6, 2012 · 2 comments
Open

Failure to send message still shows "success" #2

thbar opened this issue Dec 6, 2012 · 2 comments

Comments

@thbar
Copy link
Contributor

thbar commented Dec 6, 2012

I just did a test by unplugging my network cable, and trying to send a message.

The popup still said "success" but the console showed an error.

@madrobby
Copy link
Member

madrobby commented Dec 6, 2012

Also include OS/browser information with reports like these. Browsers are known to (unfortunately) react in different ways to problems like this.

On newer browsers, we should check navigator.onLine (https://developer.mozilla.org/en-US/docs/DOM/window.navigator.onLine)

@thbar
Copy link
Contributor Author

thbar commented Dec 6, 2012

I'm on Mac OS X 10.7.5 and the test was carried out on Chrome (Version 23.0.1271.95).

On Safari, the behaviour is different: it will apparently remain stuck on "Sending".

A probably related note (should I open a dedicated issue for that probably?): I carried out more tests by running locally a little server that raises an error 500, and success is reported for all the browsers I tried (Chrome 23.0.1271.95, FireFox 16.0.2, Safari 6.0.2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants