Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smford22/mongodb update #49

Merged
merged 3 commits into from
Sep 25, 2019
Merged

Smford22/mongodb update #49

merged 3 commits into from
Sep 25, 2019

Conversation

smford22
Copy link
Contributor

This commit addresses Issue 41 by pinning the mongodb package to version core/mongodb/3.2.10/20171016003652. Terraform code has been updated. Also added a .studiorc that will install the correct mongodb package when yo start the studio. Demoers will just need to run hab svc load core/mongodb and it will load the installed package.

…me provisioning and in local dev

Signed-off-by: Scott Ford <scott@scottford.io>
Signed-off-by: Scott Ford <scott@scottford.io>
Signed-off-by: Scott Ford <scott@scottford.io>
@smford22 smford22 requested a review from NickRycar July 29, 2019 16:29
@NickRycar
Copy link

Looks great. Only question I had is whether there is any wait time needed after starting the studio before running the hab svc load on mongodb -- is the install process quick enough that it's not really an issue that needs calling out?

@smford22
Copy link
Contributor Author

@ChefRycar Since the studio installs the pkg on hab studio enter there is no delay. As soon as the studio starts you are good to go.

@NickRycar
Copy link

Sweet. I'll set aside some time to test it out and get this approved 'n merged.

Copy link

@NickRycar NickRycar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Works great!

@smford22
Copy link
Contributor Author

@ChefRycar can you merge?

@NickRycar
Copy link

I appear to no longer be an admin after the github fun. I'll see who I can pester to get that back.

@NickRycar NickRycar merged commit 389d1cb into master Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants